Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] type parameters across multiple lines aren't highlighted properly #739

Closed
peat-psuwit opened this issue Apr 6, 2019 · 1 comment
Closed
Labels
duplicate limitation Issue is result of tmLanguage limitation where in the lookup does not go beyond current line wontfix Issue is either side effect or limitation that will not be fixed for now

Comments

@peat-psuwit
Copy link

Issue Type: Bug

The following code highlights correctly in VSCode:

Object.assign<object, object>({}, {});

However, this code does not, despite being semantically the same:

Object.assign<
  object,
  object
>({}, {});

In the latter example, assign is supposed to be function-like yellow, and small-cased object is supposed to be type-like green. Instead, both of them are generic-blue.

How VS Code highlights the above code

Steps to reproduce:

  1. Create a new file, ending with .ts.
  2. Copy both of the sample codes into the file. Observe the difference between the first & the second code.

VS Code version: Code - Insiders 1.34.0-insider (d234937aedcbc265d2272ba5861125293239f9c7, 2019-04-05T05:13:22.859Z)
OS version: Linux x64 4.15.0-46-generic

System Info
Item Value
CPUs Intel(R) Core(TM)2 Duo CPU P7350 @ 2.00GHz (2 x 1669)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: disabled_off
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
surface_synchronization: enabled_on
video_decode: unavailable_off
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 2
Memory (System) 3.60GB (0.34GB free)
Process Argv
Screen Reader no
VM 0%
Extensions: none
@mjbvz mjbvz self-assigned this Apr 7, 2019
@mjbvz mjbvz transferred this issue from microsoft/vscode Apr 8, 2019
@mjbvz mjbvz removed their assignment Apr 8, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Apr 8, 2019

Duplicate of #479 I believe

@sheetalkamat sheetalkamat added duplicate limitation Issue is result of tmLanguage limitation where in the lookup does not go beyond current line wontfix Issue is either side effect or limitation that will not be fixed for now labels Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate limitation Issue is result of tmLanguage limitation where in the lookup does not go beyond current line wontfix Issue is either side effect or limitation that will not be fixed for now
Projects
None yet
Development

No branches or pull requests

3 participants