Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting for JSDoc 3.5.0 @access package missing #986

Open
aweebit opened this issue Aug 7, 2023 · 0 comments · May be fixed by #987
Open

Highlighting for JSDoc 3.5.0 @access package missing #986

aweebit opened this issue Aug 7, 2023 · 0 comments · May be fixed by #987

Comments

@aweebit
Copy link

aweebit commented Aug 7, 2023

Noticed it while looking for an explanation on why VSCode had highlighting for the apparently undocumented @api JSDoc tag, see microsoft/vscode#189812.

JSDoc 3.5.0 introduced support for the @package tag together with the corresponding package value for the @access tag. However, the value does not currently have special highlighting in VSCode like the other supported values (private, protected, public).
@aweebit aweebit mentioned this issue Aug 7, 2023
Closed
@mjbvz mjbvz transferred this issue from microsoft/vscode Aug 7, 2023
@mjbvz mjbvz removed their assignment Aug 7, 2023
aweebit pushed a commit to aweebit/TypeScript-TmLanguage that referenced this issue Aug 8, 2023
Add support for JSDoc 3.5.0 @access package
d9de373 
Fixes microsoft#986
@aweebit aweebit linked a pull request Aug 8, 2023 that will close this issue
Open
aweebit added a commit to aweebit/TypeScript-TmLanguage that referenced this issue Aug 9, 2023
@aweebit
Add support for JSDoc 3.5.0 @access package
b18028d 
Fixes microsoft#986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mjbvz @aweebit