Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed digits at the end of method return type #240

Closed
wants to merge 1 commit into from

Conversation

RichieAHB
Copy link

@RichieAHB RichieAHB commented Aug 12, 2016

Fixes #153 - includes tests. The regex for type-annotation was looking for [a-zA-Z_$] (the regex used for the first character) as the pattern for the last character rather than [\w$]. There are a few regexes around that allows [.\w$] for the last character of a type name but as far as I can tell, type names can't end with a dot so I've not included this.

I have a plugin that removes whitespace at the end of lines so there are some rogue changes in here that I missed, which can be removed if required.

@msftclas
Copy link

Hi @RichieAHB, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@RichieAHB, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@anubmat
Copy link
Contributor

anubmat commented Sep 2, 2016

Hi @RichieAHB , this PR is similar to PR #199 . I see you have a good test here. You can either leave some comments on PR #199, or wait for that PR to be merged in and send out a PR to improve those changes.

@mhegazy
Copy link
Contributor

mhegazy commented Sep 16, 2016

Sorry for the delay. the original issue should be fixed now by #257

@mhegazy mhegazy closed this Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants