Mark template expressions with meta.embedded.line scope #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
commented
Sep 6, 2017
TypeScript.YAML-tmLanguage
Outdated
| @@ -1952,6 +1952,7 @@ repository: | |||
| '0': { name: punctuation.definition.template-expression.end.ts } | |||
| patterns: | |||
| - include: '#expression' | |||
| contentName: meta.embedded.block.ts | |||
There was a problem hiding this comment.
This should actually probably be meta.embedded.line now that I think about it more
**Problem** VS Code themes currently hardcode a solution for reseting expression colorization inside of template string substitution expressions. This is not scalable since it js/ts specific With microsoft/vscode#33120 I've proposed that VS Code themes reset styling inside of meta.embedded scopes to support this across multiple languages **Fix** Marks template substitution expressions with the additional `meta.embedded.line.ts` scope
mjbvz
changed the title
sheetalkamat
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
VS Code themes currently hardcode a solution for reseting expression colorization inside of template string substitution expressions. This is not scalable since it js/ts specific
With microsoft/vscode#33120 I've proposed that VS Code themes reset styling inside of meta.embedded scopes to support this across multiple languages
Fix
Marks template substitution expressions with the additional
meta.embedded.block.tsscope