Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow underscore in jsx attribute names #655

Merged
merged 4 commits into from
Aug 23, 2018
Merged

Allow underscore in jsx attribute names #655

merged 4 commits into from
Aug 23, 2018

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Aug 21, 2018

Fixes #648

@mjbvz mjbvz requested a review from sheetalkamat August 21, 2018 08:24
sheetalkamat
sheetalkamat reviewed Aug 21, 2018
View reviewed changes
tests/cases/Issues648.tsx
@@ -0,0 +1,5 @@
<Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line at the beginning of file to avoid generating ts grammar baseline

// @onlyOwnGrammar - As this has jsx

@sheetalkamat
Copy link
Member

Also add test case for #649

sheetalkamat
sheetalkamat requested changes Aug 21, 2018
View reviewed changes
Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix as per feedback

@mjbvz mjbvz merged commit 6de67c7 into microsoft:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjbvz @sheetalkamat