Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate fr playground sections.json #104

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Translate fr playground sections.json #104

merged 3 commits into from
Jul 23, 2021

Conversation

nfabredev
Copy link
Contributor

Taking the first item on the list of #100.

Comments / questions :

  • original strings are Title Cased - which seems common in English, but is not common in French so I've not title cased the translated strings
  • Couldn't come up with something nice for "Fixits", as it's a TS thing it might be ok to leave the original term ?
  • The translation for "Template Literals" comes from MDN

@ghost
Copy link

ghost commented Jul 22, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @ManuSquall and @Ascor8522 - if they write a comment saying "LGTM" then it will be merged.

@github-actions github-actions bot added translation fr French language translations labels Jul 22, 2021
@nfabredev nfabredev force-pushed the translate-fr-playground-sections branch from f3d65b1 to 3a46d08 Compare July 22, 2021 22:33
ManuSquall
ManuSquall reviewed Jul 22, 2021
View reviewed changes
docs/playground/fr/sections.json Outdated
{
"name": "TypeScript",
"id": "TypeScript",
"subtitle": "Explorez comment TypeScript étend JavaScript en ajoutant de la sécuritée et des outils à votre code."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sécurité sans "e" il me semble

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui c'est vrai ! Corrigé

gaelollivier
gaelollivier reviewed Jul 23, 2021
View reviewed changes
docs/playground/fr/sections.json Outdated
// Examples
"Syntaxe et messages",
"Types et flux de code",
"Fixits",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne trouve pas le contexte de ce terme, est-ce que cela réfère aux fonctionnalités "auto-fix" (par exemple: microsoft/TypeScript#31938)? Dans ce cas on pourrait traduire en "Correction automatique"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui c'est ça ! Je trouve le contexte des termes en allant sur la page du playground, et en cherchant dans les elements HTML la chaine de caractere que je dois traduire quand le contexte n'est pas clair.

"Correction automatique" sonne mieux en effet

@ManuSquall
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit 990648e into microsoft:main Jul 23, 2021
@github-actions
Copy link
Contributor

Merging because @ManuSquall is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaelollivier gaelollivier gaelollivier left review comments

@ManuSquall ManuSquall ManuSquall left review comments

Assignees
No one assigned
Labels
fr French language translations translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfabredev @ManuSquall @gaelollivier