Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-BR Version of TS for the New Programmer.md #1473

Merged
merged 5 commits into from
Jan 29, 2021
Merged

PB-BR Version of TS for the New Programmer.md #1473

merged 5 commits into from
Jan 29, 2021

Conversation

tomashugo
Copy link
Contributor

PB-BR Version of TS for the New Programmer.md

PB-BR Version of TS for the New Programmer.md
@orta
Copy link
Contributor

orta commented Jan 7, 2021

The files should be using /pt/ - not /pt-br/ which is causing your CI issues 👍🏻

@tomashugo
Copy link
Contributor Author

tomashugo commented Jan 7, 2021

The files should be using /pt/ - not /pt-br/ which is causing your CI issues 👍🏻

Ok, I've updated the file with /pt/.
Thanks.

@orta
Copy link
Contributor

orta commented Jan 7, 2021

And the filename: packages/documentation/copy/pt-BR/get-started/TS para o Novo Programador.md -> packages/documentation/copy/pt/get-started/TS para o Novo Programador.md

tomashugo and others added 3 commits January 7, 2021 14:58
PT Version of TS for the new Programmer
Put this archive from /pt-BR/ to /pt/ directory
Copy link
Contributor Author

@tomashugo tomashugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@tomashugo tomashugo closed this Jan 10, 2021
@tomashugo tomashugo reopened this Jan 10, 2021
@orta
Copy link
Contributor

orta commented Jan 25, 2021

This PR looks right to me, @khaosdoctor can you give it a review and if it still is red, I'll self-merge it when I switch to the new repo with #1480

@khaosdoctor
Copy link
Contributor

lgtm

@khaosdoctor
Copy link
Contributor

It seems finet o me too

@github-actions github-actions bot merged commit 00e12e9 into microsoft:v2 Jan 29, 2021
@github-actions
Copy link
Contributor

Merging because @khaosdoctor is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants