Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code snippets colors dimmer for dark theme enabled #1536

Merged
merged 2 commits into from
Jan 31, 2021
Merged

Make code snippets colors dimmer for dark theme enabled #1536

merged 2 commits into from
Jan 31, 2021

Conversation

falinsky
Copy link
Contributor

@falinsky falinsky commented Jan 30, 2021 •
edited by orta
Loading

A possible solution for #342

bef-vs-after

@orta
Copy link
Contributor

orta commented Jan 31, 2021

Very creative, I'd never considered or heard of this technique and I think it solves the problem well.

I've tweaked some of the colours a bit, and this looks good to go - very cool.

@orta orta merged commit f526ffb into microsoft:v2 Jan 31, 2021
@falinsky
Copy link
Contributor Author

@orta Cool! Really happy to help 🙂

@falinsky falinsky deleted the feature/code-syntax-highligh-for-dark-theme branch January 31, 2021 12:13
@schickling
Copy link
Contributor

Really interesting approach 👏

@falinsky
Copy link
Contributor Author

Really interesting approach 👏

thanks

@orta orta mentioned this pull request Feb 2, 2021
Closed
@Enter-tainer Enter-tainer mentioned this pull request Feb 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@falinsky @orta @schickling