Skip to content

48441 Adding default values to properties in reference. #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

s-dehaan
Copy link
Contributor

@ghost
Copy link

ghost commented Jul 10, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of these don't seem accurate, or are conditional on other things. e.g. baseUrl's default is not ./; it's now optional. esModuleInterop depends on module. A lot of these other ones can be "unset" and mean different things, e.g outDir and outFile are typically unset, and setting them to ./ means a different thing semantically (or is invalid).

I do appreciate the effort, but there's quite a lot that needs to be fixed up here, and at some level I'm unsure if it's worth trying to list defaults for all of these.

allowSyntheticDefaultImports: [
"`true` if [`module`](#module) is `system`, or [`esModuleInterop`](#esModuleInterop) and [`module`](#module) is not `es6`/`es2015` or `esnext`,",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super sure why all of these trailing comments have been removed; they do look correct on the reference page.

| "object"
| "list"
| Map<string, number | string>;
| "string"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the formatting changes everywhere?

jsxFactory: "React.createElement",
keyOfStringsOnly: "``false",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here.

@jakebailey jakebailey closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants