Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[moduleResolution bundler] List restrictions from initial PR in documentation #2976

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[moduleResolution bundler] List restrictions from initial PR in documentation #2976

merged 1 commit into from
Nov 15, 2023

Conversation

Ayc0
Copy link
Contributor

@Ayc0 Ayc0 commented Nov 14, 2023

In the v5.0, when the mode bundler was introduced, in the PR's description (see microsoft/TypeScript#51669), there was a list of restrictions:

Module syntax restrictions

--moduleResolution bundler does not support resolution of require calls. In TypeScript files, this means the import mod = require("foo") syntax is forbidden; in JavaScript files, require calls are not errors but only ever return the type any (or whatever an ambient declaration of a global require function is declared to return).

But those restrictions aren't listed in the doc:

image

I added those back to the main documentation.

Maybe this isn't the best place for it, and maybe it should live in the cookbook.

This is my 1st contribution to this repo so Idk if I followed every guideline.

@Ayc0 Ayc0 changed the title List restrictions from initial PR in documentation [moduleResolution bundler] List restrictions from initial PR in documentation Nov 14, 2023
@Ayc0
Copy link
Contributor Author

Ayc0 commented Nov 14, 2023

@microsoft-github-policy-service agree

@andrewbranch andrewbranch added the deploy-preview Enables automatic deployments to preview environments on a PR label Nov 15, 2023
@andrewbranch andrewbranch self-assigned this Nov 15, 2023
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-glacier-09aa73710-2976.centralus.azurestaticapps.net

@andrewbranch andrewbranch merged commit 6f5fdda into microsoft:v2 Nov 15, 2023
5 of 6 checks passed
@andrewbranch
Copy link
Member

Thanks @Ayc0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants