Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two issues in the typescript/vfs module. #3038

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Conversation

xiaoxiyao
Copy link
Contributor

@xiaoxiyao xiaoxiyao commented Mar 3, 2024

  1. 2fa00c5 Fix the exception when file content is empty.
    fix Module(vfs): throws an error when the file content is empty string #2713
  2. 3458b37 Fix moduleDetection compiler option is not working.

@tonivj5
Copy link

tonivj5 commented Apr 8, 2024

@xiaoxiyao thank you so much for the PR! ❤️ this commit 3458b37e7ff419c337bd92cb160aced73ca58058 help me a lot undestanding why the code wasn't being transpile as expected. I can confirm it works like a charm 😄

@jakebailey jakebailey added the deploy-preview Enables automatic deployments to preview environments on a PR label Jun 5, 2024
@jakebailey jakebailey closed this Jun 5, 2024
@jakebailey jakebailey reopened this Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-plant-05c166c10-3038.centralus.5.azurestaticapps.net

@jakebailey jakebailey merged commit 0ea84b5 into microsoft:v2 Jun 5, 2024
8 checks passed
@typescript-bot typescript-bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-preview Enables automatic deployments to preview environments on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module(vfs): throws an error when the file content is empty string
3 participants