Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use debug package for debug logging #3167

Open
wants to merge 6 commits into
base: v2
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: add @types/debug to devDependencies of @typescript/sandbox
kermanx committed Jun 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 5f00e054b97566ed1f4cbc5c12edcf0f47b9aa67
1 change: 1 addition & 0 deletions packages/sandbox/package.json
Original file line number Diff line number Diff line change
@@ -49,6 +49,7 @@
},
"devDependencies": {
"@rollup/plugin-commonjs": "^25.0.7",
"@types/debug": "^4.1.12",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to imply that sandbox needs a dep on debug; I think that's true given we vendor the vfs into this package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The DTS build of @typescript/sandbox would fail unless @types/debug is installed, because @typescript/vfs is vendored.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right but I mean that this package should also depend on "debug" too so the code doesn't crash.

"@types/jest": "^29.5.12",
"dts-cli": "^2.0.5",
"jest": "^29.5.0",
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.