fix: improve accessibility of "Subtype vs Assignment" table #3393
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the two styles of tick are rather hard to distinguish: two similar shades of blue / green, and two similar font weights. This PR addresses that.
Before:
After:
The "only if not strict" is now indicated by "✓*" (as opposed to just "✓").
The ✓* is now the same colour as the ✓, the "main blue", since the "muted green" was really hard to distinguish anyway, so served no purpose.
It might even be better to have these marks changed to "✕*", and comment that it's not compatible as long as
strictNullChecksistrue. Even though it's not the default, I think it's probably recognised as being good practice.