-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT-BR] Translate Conditional Types and Unknown and Never #964
Conversation
Thanks for the PR! This section of the codebase is owned by @khaosdoctor and @danilofuchs - if they write a comment saying "LGTM" then it will be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
I have a few suggestions and caught some typos
packages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes
packages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts
Outdated
Show resolved
Hide resolved
packages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts
Outdated
Show resolved
Hide resolved
@vinicius98s Corrected a few examples! |
Co-authored-by: Lucas Santos <lhs.santoss@gmail.com> Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
@khaosdoctor @danilofuchs Applied those suggestions and corrected the typos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@orta the merge action failed mysteriously 🤔 |
lgtm |
Merging because @khaosdoctor is a code-owner of all the changes - thanks! |
@danilofuchs Well... I don't know what happened |
I know, I had hoped this would solve it OSS-Docs-Tools/code-owner-self-merge#6 |
Hrm, 6 hours ago might have been before I shipped the update - so I'm not sold on it not being fixed actually - just remember to leave a review LGTM next time and we'll see |
No description provided.