Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT-BR] Translate Conditional Types and Unknown and Never #964

Merged
merged 2 commits into from
Aug 28, 2020
Merged

[PT-BR] Translate Conditional Types and Unknown and Never #964

merged 2 commits into from
Aug 28, 2020

Conversation

vinicius98s
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Aug 24, 2020

CLA assistant check
All CLA requirements met.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @khaosdoctor and @danilofuchs - if they write a comment saying "LGTM" then it will be merged.

Copy link
Contributor

@danilofuchs danilofuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
I have a few suggestions and caught some typos

Copy link
Contributor

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

@khaosdoctor
Copy link
Contributor

@vinicius98s Corrected a few examples!

Co-authored-by: Lucas Santos <lhs.santoss@gmail.com>
Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
@vinicius98s
Copy link
Contributor Author

@khaosdoctor @danilofuchs Applied those suggestions and corrected the typos

Copy link
Contributor

@danilofuchs danilofuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danilofuchs
Copy link
Contributor

@orta the merge action failed mysteriously 🤔

@khaosdoctor
Copy link
Contributor

lgtm

@github-actions github-actions bot merged commit e53888c into microsoft:v2 Aug 28, 2020
@github-actions
Copy link
Contributor

Merging because @khaosdoctor is a code-owner of all the changes - thanks!

@khaosdoctor
Copy link
Contributor

@danilofuchs Well... I don't know what happened

@orta
Copy link
Contributor

orta commented Aug 28, 2020

I know, I had hoped this would solve it OSS-Docs-Tools/code-owner-self-merge#6

@orta
Copy link
Contributor

orta commented Aug 28, 2020

Hrm, 6 hours ago might have been before I shipped the update - so I'm not sold on it not being fixed actually - just remember to leave a review LGTM next time and we'll see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants