Ignore all bots (#49)

microsoft · May 15, 2024 · 4c09fae · 4c09fae
1 parent e3855ed
commit 4c09fae
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/anyRepoHandlePullRequest.ts b/src/anyRepoHandlePullRequest.ts
@@ -64,7 +64,7 @@ const generatePRInfo = async (api: Octokit, payload: PullRequestEvent, logger: L
  return {
  thisIssue,
  authorIsMemberOfTSTeam,
- authorIsTypescriptBot: payload.pull_request.user.login === "typescript-bot",
+ authorIsBot: payload.pull_request.user.type === "Bot",
  relatedIssues,
  comments 
  }

diff --git a/src/checks/addCommentToUncommittedPRs.test.ts b/src/checks/addCommentToUncommittedPRs.test.ts
@@ -32,7 +32,7 @@ describe(addCommentToUncommittedPRs, () => {
  const pr = getPRFixture("opened")
  pr.pull_request.user.login = "typescript-bot"
 
- const info = createPRInfo({ authorIsTypescriptBot: true })
+ const info = createPRInfo({ authorIsBot: true })
  await addCommentToUncommittedPRs(api, pr, getFakeLogger(), info)
 
  expect(mockAPI.issues.createComment).not.toHaveBeenCalled()

diff --git a/src/checks/addCommentToUncommittedPRs.ts b/src/checks/addCommentToUncommittedPRs.ts
@@ -7,7 +7,7 @@ import { Logger } from "../util/logger"
  * Comment on new PRs that don't have linked issues, or link to uncommitted issues.
  */
 export const addCommentToUncommittedPRs = async (api: Octokit, payload: PullRequestEvent, logger: Logger, info: PRInfo) => {
- if (payload.pull_request.merged || payload.pull_request.draft || info.authorIsMemberOfTSTeam || info.authorIsTypescriptBot) {
+ if (payload.pull_request.merged || payload.pull_request.draft || info.authorIsMemberOfTSTeam || info.authorIsBot) {
  return logger.trace("Skipping") 
  }
 

diff --git a/src/util/tests/createPRInfo.ts b/src/util/tests/createPRInfo.ts
@@ -4,7 +4,7 @@ export const createPRInfo = (info?: Partial<PRInfo>): PRInfo => {
  return {
  comments: [],
  authorIsMemberOfTSTeam: false,
- authorIsTypescriptBot: false,
+ authorIsBot: false,
  relatedIssues: [],
  thisIssue: {
  issue_number: 35454,