rename convert to named parameters (#30401)

microsoft · Mar 14, 2019 · 1c8a359 · 1c8a359
1 parent 7ab2ad7
commit 1c8a359
Show file tree

Hide file tree

Showing 40 changed files with 109 additions and 109 deletions.
diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json
@@ -4927,7 +4927,7 @@
         "category": "Message",
         "code": 95074
     },
-    "Convert to named parameters": {
+    "Convert parameters to destructured object": {
         "category": "Message",
         "code": 95075
     }

diff --git a/...ces/refactors/convertToNamedParameters.ts → ...tors/convertParamsToDestructuredObject.ts b/...ces/refactors/convertToNamedParameters.ts → ...tors/convertParamsToDestructuredObject.ts
@@ -1,6 +1,6 @@
 /* @internal */
-namespace ts.refactor.convertToNamedParameters {
-    const refactorName = "Convert to named parameters";
+namespace ts.refactor.convertParamsToDestructuredObject {
+    const refactorName = "Convert parameters to destructured object";
     const minimumParameterLength = 2;
     registerRefactor(refactorName, { getEditsForAction, getAvailableActions });
 
@@ -12,7 +12,7 @@ namespace ts.refactor.convertToNamedParameters {
         const functionDeclaration = getFunctionDeclarationAtPosition(file, startPosition, context.program.getTypeChecker());
         if (!functionDeclaration) return emptyArray;
 
-        const description = getLocaleSpecificMessage(Diagnostics.Convert_to_named_parameters);
+        const description = getLocaleSpecificMessage(Diagnostics.Convert_parameters_to_destructured_object);
         return [{
             name: refactorName,
             description,

diff --git a/src/services/tsconfig.json b/src/services/tsconfig.json
@@ -84,7 +84,7 @@
         "refactors/generateGetAccessorAndSetAccessor.ts",
         "refactors/moveToNewFile.ts",
         "refactors/addOrRemoveBracesToArrowFunction.ts",
-        "refactors/convertToNamedParameters.ts",
+        "refactors/convertParamsToDestructuredObject.ts",
         "services.ts",
         "breakpoints.ts",
         "transform.ts",

diff --git a/...ertToNamedParameters_allParamsOptional.ts → ...ToDestructuredObject_allParamsOptional.ts b/...ertToNamedParameters_allParamsOptional.ts → ...ToDestructuredObject_allParamsOptional.ts
@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b = "1" }: { a?: number; b?: string; } = {}): string {
     return b;
 }

diff --git a/...ConvertToNamedParameters_arrowFunction.ts → ...ramsToDestructuredObject_arrowFunction.ts b/...ConvertToNamedParameters_arrowFunction.ts → ...ramsToDestructuredObject_arrowFunction.ts
@@ -5,9 +5,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const foo = ({ a, b }: { a: number; b: number; }) => { };
 foo({ a: 1, b: 2 });`
 });
diff --git a/...meters_arrowFunctionWithContextualType.ts → ...structuredObject_arrowFunctionWithType.ts b/...meters_arrowFunctionWithContextualType.ts → ...structuredObject_arrowFunctionWithType.ts
@@ -4,4 +4,4 @@
 ////foo(1, 2);
 
 goTo.select("a", "b");
-verify.not.refactorAvailable("Convert to named parameters");
+verify.not.refactorAvailable("Convert parameters to destructured object");
diff --git a/...rConvertToNamedParameters_callComments.ts → ...aramsToDestructuredObject_callComments.ts b/...rConvertToNamedParameters_callComments.ts → ...aramsToDestructuredObject_callComments.ts
@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b, rest = [] }: { a: number; b: number; rest?: number[]; }) {
     return a + b;
 }

diff --git a/...ConvertToNamedParameters_callComments2.ts → ...ramsToDestructuredObject_callComments2.ts b/...ConvertToNamedParameters_callComments2.ts → ...ramsToDestructuredObject_callComments2.ts
@@ -16,9 +16,9 @@
 goTo.select("a", "b");
 /* The expected content is currently wrong. The new argument object has the wrong formatting. */
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b, rest = [] }: { a: number; b: number; rest?: number[]; }) {
     return a + b;
 }

diff --git a/...orConvertToNamedParameters_chainedCall.ts → ...ParamsToDestructuredObject_chainedCall.ts b/...orConvertToNamedParameters_chainedCall.ts → ...ParamsToDestructuredObject_chainedCall.ts
@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b }: { a: number; b: number; }) {
     return { bar: () => a + b };
 }

diff --git a/...medParameters_classDeclarationAliasing.ts → ...ucturedObject_classDeclarationAliasing.ts b/...medParameters_classDeclarationAliasing.ts → ...ucturedObject_classDeclarationAliasing.ts
@@ -9,9 +9,9 @@
 goTo.select("a", "b");
 // Refactor should not make changes
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     constructor(a: number, b: number) { }
 }

diff --git a/...dParameters_classDeclarationGoodUsages.ts → ...turedObject_classDeclarationGoodUsages.ts b/...dParameters_classDeclarationGoodUsages.ts → ...turedObject_classDeclarationGoodUsages.ts
@@ -14,9 +14,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class C {
     static a: number = 2;
     constructor({ a, b }: { a: number; b: number; }) { }

diff --git a/...nvertToNamedParameters_classExpression.ts → ...msToDestructuredObject_classExpression.ts b/...nvertToNamedParameters_classExpression.ts → ...msToDestructuredObject_classExpression.ts
@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const c = class {
     constructor({ a, b = { x: 1 } }: { a: number; b?: { x: number; }; }) { }
 }

diff --git a/...edParameters_classExpressionGoodUsages.ts → ...cturedObject_classExpressionGoodUsages.ts b/...edParameters_classExpressionGoodUsages.ts → ...cturedObject_classExpressionGoodUsages.ts
@@ -10,9 +10,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const c = class C {
     static a: number = 2;
     constructor({ a, b }: { a: number; b: number; }) { }

diff --git a/...amedParameters_classExpressionHeritage.ts → ...ructuredObject_classExpressionHeritage.ts b/...amedParameters_classExpressionHeritage.ts → ...ructuredObject_classExpressionHeritage.ts
@@ -12,9 +12,9 @@
 goTo.select("a", "b");
 // Refactor should not make changes
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const foo = class Foo {
     constructor(a: number, b: number) { }
 }

diff --git a/...tToNamedParameters_classTypeParameters.ts → ...DestructuredObject_classTypeParameters.ts b/...tToNamedParameters_classTypeParameters.ts → ...DestructuredObject_classTypeParameters.ts
@@ -10,9 +10,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo<T> {
     bar({ t, s }: { t: T; s: T; }) {
         return s;

diff --git a/...orConvertToNamedParameters_constructor.ts → ...ParamsToDestructuredObject_constructor.ts b/...orConvertToNamedParameters_constructor.ts → ...ParamsToDestructuredObject_constructor.ts
@@ -12,9 +12,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     t: string;
     s: string;

diff --git a/...rConvertToNamedParameters_defaultClass.ts → ...aramsToDestructuredObject_defaultClass.ts b/...rConvertToNamedParameters_defaultClass.ts → ...aramsToDestructuredObject_defaultClass.ts
@@ -5,4 +5,4 @@
 ////}
 
 goTo.select("a", "b");
-verify.not.refactorAvailable("Convert to named parameters");
+verify.not.refactorAvailable("Convert parameters to destructured object");
diff --git a/...actorConvertToNamedParameters_function.ts → ...ertParamsToDestructuredObject_function.ts b/...actorConvertToNamedParameters_function.ts → ...ertParamsToDestructuredObject_function.ts
@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b }: { a: number; b: string; }): string {
     return b;
 }

diff --git a/...vertToNamedParameters_functionComments.ts → ...sToDestructuredObject_functionComments.ts b/...vertToNamedParameters_functionComments.ts → ...sToDestructuredObject_functionComments.ts
@@ -10,9 +10,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `foo({ a: 1, b: 2 }); /**a*/
 /**b*/ function foo(/**this1*/ this /**this2*/: /**void1*/ void /**void2*/, { a, b = /**k*/ 1 /**l*/ }: { /**c*/ a /**d*/: /**e*/ number /**f*/; /**g*/ b /**h*/?: /**i*/ number /**j*/; }) {
     // m

diff --git a/...ertToNamedParameters_functionComments1.ts → ...ToDestructuredObject_functionComments1.ts b/...ertToNamedParameters_functionComments1.ts → ...ToDestructuredObject_functionComments1.ts
@@ -6,9 +6,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo({ a, b }: { a: number /** a */; b: number /** b */; }) {
     return a + b;
 }`

diff --git a/...ertToNamedParameters_functionComments2.ts → ...ToDestructuredObject_functionComments2.ts b/...ertToNamedParameters_functionComments2.ts → ...ToDestructuredObject_functionComments2.ts
@@ -11,9 +11,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo(// comment
 { a, b }: {
     // a comment

diff --git a/...rtToNamedParameters_functionExpression.ts → ...oDestructuredObject_functionExpression.ts b/...rtToNamedParameters_functionExpression.ts → ...oDestructuredObject_functionExpression.ts
@@ -5,9 +5,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `const foo = function({ a, b }: { a: number; b: number; }) { };
 foo({ a: 1, b: 2 });`
 });
diff --git a/...NamedParameters_functionTypeParameters.ts → ...tructuredObject_functionTypeParameters.ts b/...NamedParameters_functionTypeParameters.ts → ...tructuredObject_functionTypeParameters.ts
@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function foo<T, S>({ t, s }: { t: T; s: S; }) {
     return s;
 }

diff --git a/...ToNamedParameters_inheritedConstructor.ts → ...estructuredObject_inheritedConstructor.ts b/...ToNamedParameters_inheritedConstructor.ts → ...estructuredObject_inheritedConstructor.ts
@@ -12,9 +12,9 @@ goTo.select("a", "b");
     `new Bar("a", "b")` should be modified by the refactor to be `new Bar({ t: "a", s: "b" })`
 */
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     constructor({ t, s }: { t: string; s: string; }) { }
 }

diff --git a/...nvertToNamedParameters_inheritedMethod.ts → ...msToDestructuredObject_inheritedMethod.ts b/...nvertToNamedParameters_inheritedMethod.ts → ...msToDestructuredObject_inheritedMethod.ts
@@ -11,9 +11,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     bar({ t, s }: { t: string; s: string; }): string {
         return s + t;

diff --git a/...orConvertToNamedParameters_initializer.ts → ...ParamsToDestructuredObject_initializer.ts b/...orConvertToNamedParameters_initializer.ts → ...ParamsToDestructuredObject_initializer.ts
@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b = "1" }: { a: number; b?: string; }): string {
     return b;
 }

diff --git a/...ToNamedParameters_initializerInference.ts → ...estructuredObject_initializerInference.ts b/...ToNamedParameters_initializerInference.ts → ...estructuredObject_initializerInference.ts
@@ -7,9 +7,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `function f({ a, b = { x: 1, z: { s: true } } }: { a: number; b?: { x: number; z: { s: boolean; }; }; }) {
     return b;
 }

diff --git a/...efactorConvertToNamedParameters_method.ts → ...nvertParamsToDestructuredObject_method.ts b/...efactorConvertToNamedParameters_method.ts → ...nvertParamsToDestructuredObject_method.ts
@@ -10,9 +10,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     bar({ t, s }: { t: string; s: string; }): string {
         return s + t;

diff --git a/...nvertToNamedParameters_methodCallUnion.ts → ...msToDestructuredObject_methodCallUnion.ts b/...nvertToNamedParameters_methodCallUnion.ts → ...msToDestructuredObject_methodCallUnion.ts
@@ -14,9 +14,9 @@
 goTo.select("a", "b");
 // Refactor should not make changes
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class A {
     foo(a: number, b: number) { return a + b; }
 }

diff --git a/...orConvertToNamedParameters_methodCalls.ts → ...ParamsToDestructuredObject_methodCalls.ts b/...orConvertToNamedParameters_methodCalls.ts → ...ParamsToDestructuredObject_methodCalls.ts
@@ -11,9 +11,9 @@
 
 goTo.select("a", "b");
 edit.applyRefactor({
-    refactorName: "Convert to named parameters",
-    actionName: "Convert to named parameters",
-    actionDescription: "Convert to named parameters",
+    refactorName: "Convert parameters to destructured object",
+    actionName: "Convert parameters to destructured object",
+    actionDescription: "Convert parameters to destructured object",
     newContent: `class Foo {
     bar({ t, s }: { t: string; s: string; }): string {
         return s + t;