🤖 Pick PR #53481 (Retry string completions from the i...) into releas…

…e-5.0 (#53551) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
microsoft · Mar 28, 2023 · 1e70bb8 · 1e70bb8
1 parent 7e093f0
commit 1e70bb8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/services/stringCompletions.ts b/src/services/stringCompletions.ts
@@ -439,7 +439,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL
             const literals = contextualTypes.types.filter(literal => !tracker.hasValue(literal.value));
             return { kind: StringLiteralCompletionKind.Types, types: literals, isNewIdentifier: false };
         default:
-            return fromContextualType();
+            return fromContextualType() || fromContextualType(ContextFlags.None);
     }
 
     function fromContextualType(contextFlags: ContextFlags = ContextFlags.Completions): StringLiteralCompletionsFromTypes | undefined {

diff --git a/tests/cases/fourslash/completionsLiteralFromInferenceWithinInferredType3.ts b/tests/cases/fourslash/completionsLiteralFromInferenceWithinInferredType3.ts
@@ -0,0 +1,16 @@
+/// <reference path="fourslash.ts" />
+
+//// declare function test<T>(a: {
+////   [K in keyof T]: {
+////     b?: (keyof T)[];
+////   };
+//// }): void;
+////
+//// test({
+////   foo: {},
+////   bar: {
+////     b: ["/*ts*/"],
+////   },
+//// });
+
+verify.completions({ marker: ["ts"], exact: ["foo", "bar"] });