Retry string completions from the inferred type by default #53481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Andarist
commented
Mar 23, 2023
| @@ -439,7 +439,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL | |||
| const literals = contextualTypes.types.filter(literal => !tracker.hasValue(literal.value)); | |||
| return { kind: StringLiteralCompletionKind.Types, types: literals, isNewIdentifier: false }; | |||
| default: | |||
| return fromContextualType(); | |||
| return fromContextualType() || fromContextualType(ContextFlags.None); | |||
There was a problem hiding this comment.
a more conservative approach would be to do this:
case SyntaxKind.ArrayLiteralExpression:
return fromContextualType() || fromContextualType(ContextFlags.None);
default:
return fromContextualType();i went for a broad fix~ but perhaps some node types should not be subjects for those retries?
andrewbranch
approved these changes
Mar 23, 2023
|
Is this something we need to be backporting? Per #53475 (comment) this is a 5.0 regression, so it's probably good to get in before we send it out? |
|
@typescript-bot user test tsserver |
|
Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at ea75390. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the diff-based user code test suite (tsserver) on this PR at ea75390. You can monitor the build here. Update: The results are in! |
|
Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite (tsserver) on this PR at ea75390. You can monitor the build here. Update: The results are in! |
|
@DanielRosenwasser Here are the results of running the user test suite comparing Everything looks good! |
|
@DanielRosenwasser Here they are:
CompilerComparison Report - main..53481
System
Hosts
Scenarios
TSServerComparison Report - main..53481
System
Hosts
Scenarios
StartupComparison Report - main..53481
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@DanielRosenwasser Here are the results of running the top-repos suite comparing Everything looks good! |
|
@typescript-bot cherry-pick this to release-5.0 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
I'll tentatively cherry-pick. |
|
Hey @DanielRosenwasser, I've opened #53551 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 28, 2023
Component commits: ea75390 Retry string completions from the inferred type by default
|
Thanks guys! |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Mar 28, 2023
…e-5.0 (#53551) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
drivron
pushed a commit
to scenari/typescript
that referenced
this pull request
Sep 14, 2023
…to release-5.0 (microsoft#53551) Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53475
I'm using the same strategy to retry those requests as the one used in https://github.com/microsoft/TypeScript/pull/52875/files
cc @andrewbranch