Retain old behavior in compile on save by disabling use of file versi…

…on as signature in when state is not reused
microsoft · Mar 22, 2021 · 23e6625 · 23e6625
1 parent 74d5349
commit 23e6625
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 845 deletions.
diff --git a/src/server/project.ts b/src/server/project.ts
@@ -640,7 +640,7 @@ namespace ts.server {
  return [];
  }
  updateProjectIfDirty(this);
- this.builderState = BuilderState.create(this.program!, this.projectService.toCanonicalFileName, this.builderState);
+ this.builderState = BuilderState.create(this.program!, this.projectService.toCanonicalFileName, this.builderState, /*disableUseFileVersionAsSignature*/ true);
  return mapDefined(
  BuilderState.getFilesAffectedBy(
  this.builderState,

diff --git a/src/testRunner/unittests/tsserver/compileOnSave.ts b/src/testRunner/unittests/tsserver/compileOnSave.ts
@@ -951,14 +951,10 @@ function bar() {
  }
 
  // Change file1 get affected file list
- verifyLocalEdit(file1, "hello", "world", /*returnsAllFilesAsAffected*/ !declaration); // Signatures are not initialized before this request
- verifyLocalEdit(file1, "world", "hello");
  verifyLocalEdit(file1, "hello", "world");
 
  // Change file2 get affected file list = will return only file2 if --declaration otherwise all files
  verifyLocalEdit(file2, "world", "hello", /*returnsAllFilesAsAffected*/ !declaration);
- verifyLocalEdit(file2, "hello", "world");
- verifyLocalEdit(file2, "world", "hello");
 
  function verifyFileSave(file: File) {
  const response = session.executeCommandSeq<protocol.CompileOnSaveEmitFileRequest>({