Non composite projects dont need to track declaration change time

microsoft · Apr 19, 2022 · 2f2e370 · 2f2e370
1 parent fcf07f8
commit 2f2e370
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 25 deletions.
diff --git a/src/compiler/tsbuildPublic.ts b/src/compiler/tsbuildPublic.ts
@@ -990,7 +990,9 @@ namespace ts {
                 if (resultFlags === BuildResultFlags.DeclarationOutputUnchanged && isDeclarationFileName(name)) {
                     // Check for unchanged .d.ts files
                     if (state.readFileWithCache(name) === text) {
-                        newestDeclarationFileContentChangedTime = newer(newestDeclarationFileContentChangedTime, ts.getModifiedTime(host, name));
+                        if (config.options.composite) {
+                            newestDeclarationFileContentChangedTime = newer(newestDeclarationFileContentChangedTime, ts.getModifiedTime(host, name));
+                        }
                     }
                     else {
                         resultFlags &= ~BuildResultFlags.DeclarationOutputUnchanged;
@@ -1506,7 +1508,6 @@ namespace ts {
         const buildInfoPath = getTsBuildInfoEmitOutputFilePath(project.options);
         let oldestOutputFileName = "(none)";
         let oldestOutputFileTime = maximumDate;
-        let newestDeclarationFileContentChangedTime;
         let buildInfoTime: Date | undefined;
         if (buildInfoPath) {
             const buildInfoCacheEntry = getBuildInfoCacheEntry(state, buildInfoPath, resolvedPath);
@@ -1599,14 +1600,6 @@ namespace ts {
                         newerInputFileName: newestInputFileName
                     };
                 }
-
-                // Keep track of when the most recent time a .d.ts file was changed.
-                // In addition to file timestamps, we also keep track of when a .d.ts file
-                // had its file touched but not had its contents changed - this allows us
-                // to skip a downstream typecheck
-                if (isDeclarationFileName(output)) {
-                    newestDeclarationFileContentChangedTime = newer(newestDeclarationFileContentChangedTime, outputTime);
-                }
             }
         }
 
@@ -1666,7 +1659,7 @@ namespace ts {
         // Up to date
         return {
             type: pseudoUpToDate ? UpToDateStatusType.UpToDateWithUpstreamTypes : UpToDateStatusType.UpToDate,
-            newestDeclarationFileContentChangedTime,
+            newestDeclarationFileContentChangedTime: undefined,
             newestInputFileTime,
             newestInputFileName,
             oldestOutputFileName
@@ -1706,7 +1699,7 @@ namespace ts {
                     continue;
                 }
 
-                if (!anyDtsChange && isDeclarationFileName(file)) {
+                if (proj.options.composite && !anyDtsChange && isDeclarationFileName(file)) {
                     newestDeclarationFileContentChangedTime = newer(newestDeclarationFileContentChangedTime, ts.getModifiedTime(host, file));
                 }
 

diff --git a/...rredTypeFromTransitiveModule/inferred-type-from-transitive-module-with-isolatedModules.js b/...rredTypeFromTransitiveModule/inferred-type-from-transitive-module-with-isolatedModules.js
@@ -286,8 +286,7 @@ exitCode:: ExitStatus.Success
 
 getModifiedTime:: {
  "/src/obj/tsconfig.tsbuildinfo": 1,
- "/src/bar.ts": 1,
- "/src/obj/lazyIndex.d.ts": 1
+ "/src/bar.ts": 1
 }
 
 setModifiedTime:: {}
@@ -440,8 +439,7 @@ exitCode:: ExitStatus.Success
 
 getModifiedTime:: {
  "/src/obj/tsconfig.tsbuildinfo": 1,
- "/src/bar.ts": 1,
- "/src/obj/lazyIndex.d.ts": 1
+ "/src/bar.ts": 1
 }
 
 setModifiedTime:: {}

diff --git a/...iveModule/reports-errors-in-files-affected-by-change-in-signature-with-isolatedModules.js b/...iveModule/reports-errors-in-files-affected-by-change-in-signature-with-isolatedModules.js
@@ -458,11 +458,7 @@ Output::
 exitCode:: ExitStatus.Success
 
 getModifiedTime:: {
- "/src/obj/tsconfig.tsbuildinfo": 1,
- "/src/obj/bar.d.ts": 1,
- "/src/obj/index.d.ts": 1,
- "/src/obj/lazyIndex.d.ts": 1,
- "/src/obj/bundling.d.ts": 1
+ "/src/obj/tsconfig.tsbuildinfo": 1
 }
 
 setModifiedTime:: {}

diff --git a/...rebuilds-completely-when-command-line-incremental-flag-changes-between-non-dts-changes.js b/...rebuilds-completely-when-command-line-incremental-flag-changes-between-non-dts-changes.js
@@ -628,7 +628,7 @@ getModifiedTime:: {
  "/src/third/third_part1.ts": 1,
  "/src/third/thirdjs/output/third-output.js": 1,
  "/src/third/thirdjs/output/third-output.js.map": 1,
- "/src/third/thirdjs/output/third-output.d.ts": 2,
+ "/src/third/thirdjs/output/third-output.d.ts": 1,
  "/src/third/thirdjs/output/third-output.d.ts.map": 1,
  "/src/third/tsconfig.json": 1
 }
@@ -808,8 +808,7 @@ getModifiedTime:: {
  "/src/second/second_part2.ts": 1,
  "/src/second/tsconfig.json": 1,
  "/src/third/thirdjs/output/third-output.tsbuildinfo": 1,
- "/src/third/third_part1.ts": 1,
- "/src/third/thirdjs/output/third-output.d.ts": 1
+ "/src/third/third_part1.ts": 1
 }
 
 setModifiedTime:: {}

diff --git a/...tsbuild/outfile-concat/when-final-project-is-not-composite-but-uses-project-references.js b/...tsbuild/outfile-concat/when-final-project-is-not-composite-but-uses-project-references.js
@@ -1778,7 +1778,7 @@ getModifiedTime:: {
  "/src/third/third_part1.ts": 1,
  "/src/third/thirdjs/output/third-output.js": 1,
  "/src/third/thirdjs/output/third-output.js.map": 1,
- "/src/third/thirdjs/output/third-output.d.ts": 2,
+ "/src/third/thirdjs/output/third-output.d.ts": 1,
  "/src/third/thirdjs/output/third-output.d.ts.map": 1,
  "/src/third/tsconfig.json": 1
 }