-
Notifications
You must be signed in to change notification settings - Fork 12.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reuse input nodes where possible when serializing jsdoc implements cl…
…auses (#41783) * Reuse input nodes where possible when serializing jsdoc implements clauses * Whitespace changes, per PR feedback
- Loading branch information
Showing
6 changed files
with
242 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
tests/baselines/reference/jsDeclarationsClassImplementsGenericsSerialization.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| //// [tests/cases/conformance/jsdoc/declarations/jsDeclarationsClassImplementsGenericsSerialization.ts] //// | ||
|
|
||
| //// [interface.ts] | ||
| export interface Encoder<T> { | ||
| encode(value: T): Uint8Array | ||
| } | ||
| //// [lib.js] | ||
| /** | ||
| * @template T | ||
| * @implements {IEncoder<T>} | ||
| */ | ||
| export class Encoder { | ||
| /** | ||
| * @param {T} value | ||
| */ | ||
| encode(value) { | ||
| return new Uint8Array(0) | ||
| } | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * @template T | ||
| * @typedef {import('./interface').Encoder<T>} IEncoder | ||
| */ | ||
|
|
||
| //// [interface.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| //// [lib.js] | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.Encoder = void 0; | ||
| /** | ||
| * @template T | ||
| * @implements {IEncoder<T>} | ||
| */ | ||
| var Encoder = /** @class */ (function () { | ||
| function Encoder() { | ||
| } | ||
| /** | ||
| * @param {T} value | ||
| */ | ||
| Encoder.prototype.encode = function (value) { | ||
| return new Uint8Array(0); | ||
| }; | ||
| return Encoder; | ||
| }()); | ||
| exports.Encoder = Encoder; | ||
| /** | ||
| * @template T | ||
| * @typedef {import('./interface').Encoder<T>} IEncoder | ||
| */ | ||
|
|
||
|
|
||
| //// [interface.d.ts] | ||
| export interface Encoder<T> { | ||
| encode(value: T): Uint8Array; | ||
| } | ||
| //// [lib.d.ts] | ||
| /** | ||
| * @template T | ||
| * @implements {IEncoder<T>} | ||
| */ | ||
| export class Encoder<T> implements IEncoder<T> { | ||
| /** | ||
| * @param {T} value | ||
| */ | ||
| encode(value: T): Uint8Array; | ||
| } | ||
| export type IEncoder<T> = import("./interface").Encoder<T>; |
36 changes: 36 additions & 0 deletions
36
tests/baselines/reference/jsDeclarationsClassImplementsGenericsSerialization.symbols
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| === tests/cases/conformance/jsdoc/declarations/interface.ts === | ||
| export interface Encoder<T> { | ||
| >Encoder : Symbol(Encoder, Decl(interface.ts, 0, 0)) | ||
| >T : Symbol(T, Decl(interface.ts, 0, 25)) | ||
|
|
||
| encode(value: T): Uint8Array | ||
| >encode : Symbol(Encoder.encode, Decl(interface.ts, 0, 29)) | ||
| >value : Symbol(value, Decl(interface.ts, 1, 11)) | ||
| >T : Symbol(T, Decl(interface.ts, 0, 25)) | ||
| >Uint8Array : Symbol(Uint8Array, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --)) | ||
| } | ||
| === tests/cases/conformance/jsdoc/declarations/lib.js === | ||
| /** | ||
| * @template T | ||
| * @implements {IEncoder<T>} | ||
| */ | ||
| export class Encoder { | ||
| >Encoder : Symbol(Encoder, Decl(lib.js, 0, 0)) | ||
|
|
||
| /** | ||
| * @param {T} value | ||
| */ | ||
| encode(value) { | ||
| >encode : Symbol(Encoder.encode, Decl(lib.js, 4, 22)) | ||
| >value : Symbol(value, Decl(lib.js, 8, 11)) | ||
|
|
||
| return new Uint8Array(0) | ||
| >Uint8Array : Symbol(Uint8Array, Decl(lib.es5.d.ts, --, --), Decl(lib.es5.d.ts, --, --)) | ||
| } | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * @template T | ||
| * @typedef {import('./interface').Encoder<T>} IEncoder | ||
| */ |
33 changes: 33 additions & 0 deletions
33
tests/baselines/reference/jsDeclarationsClassImplementsGenericsSerialization.types
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| === tests/cases/conformance/jsdoc/declarations/interface.ts === | ||
| export interface Encoder<T> { | ||
| encode(value: T): Uint8Array | ||
| >encode : (value: T) => Uint8Array | ||
| >value : T | ||
| } | ||
| === tests/cases/conformance/jsdoc/declarations/lib.js === | ||
| /** | ||
| * @template T | ||
| * @implements {IEncoder<T>} | ||
| */ | ||
| export class Encoder { | ||
| >Encoder : Encoder<T> | ||
|
|
||
| /** | ||
| * @param {T} value | ||
| */ | ||
| encode(value) { | ||
| >encode : (value: T) => Uint8Array | ||
| >value : T | ||
|
|
||
| return new Uint8Array(0) | ||
| >new Uint8Array(0) : Uint8Array | ||
| >Uint8Array : Uint8ArrayConstructor | ||
| >0 : 0 | ||
| } | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * @template T | ||
| * @typedef {import('./interface').Encoder<T>} IEncoder | ||
| */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
...ases/conformance/jsdoc/declarations/jsDeclarationsClassImplementsGenericsSerialization.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // @allowJs: true | ||
| // @checkJs: true | ||
| // @target: es5 | ||
| // @outDir: ./out | ||
| // @declaration: true | ||
| // @filename: interface.ts | ||
| export interface Encoder<T> { | ||
| encode(value: T): Uint8Array | ||
| } | ||
| // @filename: lib.js | ||
| /** | ||
| * @template T | ||
| * @implements {IEncoder<T>} | ||
| */ | ||
| export class Encoder { | ||
| /** | ||
| * @param {T} value | ||
| */ | ||
| encode(value) { | ||
| return new Uint8Array(0) | ||
| } | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * @template T | ||
| * @typedef {import('./interface').Encoder<T>} IEncoder | ||
| */ |