Bump target up to ES2015

microsoft · Jul 24, 2022 · 7753eae · 7753eae
1 parent 966e732
commit 7753eae
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/scripts/importDefinitelyTypedTests/tsconfig.json b/scripts/importDefinitelyTypedTests/tsconfig.json
@@ -1,7 +1,7 @@
 {
     "compilerOptions": {
         "module": "commonjs",
-        "target": "ES5",
+        "target": "ES2015",
         "outDir": "./",
         "rootDir": ".",
         "newLine": "lf",
@@ -15,4 +15,4 @@
     ],
     "exclude": [
     ]
-}
+}
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -27009,10 +27009,10 @@ namespace ts {
                 case AssignmentDeclarationKind.ExportsProperty:
                 case AssignmentDeclarationKind.Prototype:
                 case AssignmentDeclarationKind.PrototypeProperty:
-                    let valueDeclaration = binaryExpression.left.symbol?.valueDeclaration;
-                    // falls through
                 case AssignmentDeclarationKind.ModuleExports:
-                    valueDeclaration ||= binaryExpression.symbol?.valueDeclaration;
+                    const valueDeclaration = kind !== AssignmentDeclarationKind.ModuleExports
+                        ? binaryExpression.left.symbol?.valueDeclaration
+                        : binaryExpression.symbol?.valueDeclaration;
                     const annotated = valueDeclaration && getEffectiveTypeAnnotationNode(valueDeclaration);
                     return annotated ? getTypeFromTypeNode(annotated) : undefined;
                 case AssignmentDeclarationKind.ObjectDefinePropertyValue:

diff --git a/src/instrumenter/tsconfig.json b/src/instrumenter/tsconfig.json
@@ -1,7 +1,7 @@
 {
     "compilerOptions": {
         "module": "commonjs",
-        "target": "es5",
+        "target": "ES2015",
         "lib": [
             "es6",
             "dom",
@@ -13,4 +13,4 @@
     "files": [
         "instrumenter.ts"
     ]
-}
+}
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -1363,6 +1363,8 @@ namespace ts {
                 onUnRecoverableConfigFileDiagnostic: noop,
             };
 
+            const documentRegistryBucketKey = documentRegistry.getKeyForCompilationSettings(newSettings);
+
             // If the program is already up-to-date, we can reuse it
             if (isProgramUptoDate(program, rootFileNames, newSettings, (_path, fileName) => host.getScriptVersion(fileName), fileName => compilerHost!.fileExists(fileName), hasInvalidatedResolution, hasChangedAutomaticTypeDirectiveNames, getParsedCommandLine, projectReferences)) {
                 return;
@@ -1374,7 +1376,6 @@ namespace ts {
             // the program points to old source files that have been invalidated because of
             // incremental parsing.
 
-            const documentRegistryBucketKey = documentRegistry.getKeyForCompilationSettings(newSettings);
             const options: CreateProgramOptions = {
                 rootNames: rootFileNames,
                 options: newSettings,

diff --git a/src/tsconfig-base.json b/src/tsconfig-base.json
@@ -2,7 +2,7 @@
     "compilerOptions": {
         "pretty": true,
         "lib": ["es2015.iterable", "es2015.generator", "es5"],
-        "target": "es5",
+        "target": "ES2015",
         "moduleResolution": "node",
         "rootDir": ".",