Fixed a JSDoc-related crash when obtaining type of a type literal typ…

…e argument (#60358)
microsoft · Oct 28, 2024 · cb44488 · cb44488
1 parent 6beca69
commit cb44488
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -19362,7 +19362,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         if (!links.resolvedType) {
             // Deferred resolution of members is handled by resolveObjectTypeMembers
             const aliasSymbol = getAliasSymbolForTypeNode(node);
-            if (getMembersOfSymbol(node.symbol).size === 0 && !aliasSymbol) {
+            if (!node.symbol || getMembersOfSymbol(node.symbol).size === 0 && !aliasSymbol) {
                 links.resolvedType = emptyTypeLiteralType;
             }
             else {

diff --git a/tests/cases/fourslash/completionsJSDocNoCrash3.ts b/tests/cases/fourslash/completionsJSDocNoCrash3.ts
@@ -0,0 +1,25 @@
+/// <reference path='fourslash.ts' />
+
+// @strict: true
+
+// @filename: index.ts
+//// class MssqlClient {
+////   /**
+////    *
+////    * @param {Object} - args
+////    * @param {String} - args.parentTable
+////    * @returns {Promise<{upStatement/**/, downStatement}>}
+////    */
+////   async relationCreate(args) {}
+//// }
+////
+//// export default MssqlClient;
+
+verify.completions({
+  marker: "",
+  exact: [{
+    name: "readonly",
+    sortText: completion.SortText.GlobalsOrKeywords,
+  }],
+  isNewIdentifierLocation: true,
+});