Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion list showing bogus completions #11217

Closed
waderyan opened this issue Sep 28, 2016 · 1 comment
Closed

Completion list showing bogus completions #11217

waderyan opened this issue Sep 28, 2016 · 1 comment
Assignees
@sheetalkamat
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Milestone
TypeScript 2.0.6

Comments

@waderyan
Copy link

waderyan commented Sep 28, 2016 •
edited
Loading

Original Issue - microsoft/vscode#12849, reported by @mousetraps

Testing microsoft/vscode#12598

VS Code Insiders 1.6

[Symbol.hasInstance] should not appear in the list.
image
@waderyan waderyan added VS Code Tracked There is a VS Code equivalent to this issue Bug A bug in TypeScript labels Sep 28, 2016
@waderyan
Copy link
Author

Reproduced

image

@waderyan waderyan mentioned this issue Sep 28, 2016
Closed
@mhegazy mhegazy added this to the TypeScript 2.1 milestone Sep 28, 2016
@mhegazy mhegazy assigned ghost and sheetalkamat and unassigned ghost Sep 28, 2016
sheetalkamat added a commit that referenced this issue Oct 5, 2016
@sheetalkamat
Even in javascript files when creating completion entry from symbols …
1e0e020 
…we need to perform identifier check

Fixes #11217
@sheetalkamat sheetalkamat mentioned this issue Oct 5, 2016
Merged
sheetalkamat added a commit that referenced this issue Oct 6, 2016
@sheetalkamat
Even in javascript files when creating completion entry from symbols …
f308747 
…we need to perform identifier check

Fixes #11217
@sheetalkamat sheetalkamat mentioned this issue Oct 6, 2016
Merged
@sheetalkamat sheetalkamat added the Fixed A PR has been merged for this issue label Oct 6, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sheetalkamat sheetalkamat

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
TypeScript 2.0.6
Development

No branches or pull requests
3 participants
@waderyan @mhegazy @sheetalkamat