-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Multiple projects linked by npm link do not compile properly within vscode #12080
Comments
@andy-ms can you take a look. |
@kayahr, just to be sure, could you test this out on your computer with tomorrow's build? |
Yes, it works with 2.1.0-dev.20161108. In 2.0.8 it is still broken. Will this fix be merged into the release branch so it will land in 2.0.9? |
The fix will be in the final release of TypeScript 2.1 |
No chance to get this fix in 2.0? It was fixed before for 2.0.2 and now its broken again which means we are stuck at 2.0.2 until 2.1 is released. |
TypeScript Version: 2.0.6, 2.0.7 and 2.1.0-dev.20161107
VSCode Version: 1.7.1
OS Version: Debian GNU/Linux 8.6
This is a regression of #9585. The original problem was fixed in TypeScript 2.0.2 but since 2.0.6 the problem is back. Here is a copy of the reproduction instructions which are still correct (But I haven't made a new screenshot because it would just show the same error with a different TypeScript version):
Steps to reproduce:
Globally install TypeScript (Current is 2.0.7) with "npm install -g typescript"
Install latest vscode (Current is 1.7.1)
Configure vscode to use the globally installed TypeScript by setting the typescript.tsdk path in the user settings.
Unpack the projects.zip
archive somewhere.
Run
npm link
inprojects/base
.Run
npm link base
inprojects/ui
.Run
npm link
inprojects/ui
.Run
npm link base
inprojects/application
.Run
npm link ui
inprojects/application
.Run
tsc
inprojects/application
and notice that it compiles correctly.Now open
projects/application
in vscode and open the filesrc/main/Impl.ts
. The following error is displayed:Press Ctrl-Shift-B to compile the project with the command line compiler. The error disappears.
Edit the file (inserting a whitespace for example) and the error re-appears.
So while the project compiles fine on the command line (Running
tsc
directly) it doesn't compile within vscode which uses the exact same compiler.Here is a screenshot of the error message:
The text was updated successfully, but these errors were encountered: