Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate if field is optional #12458

Closed
normalser opened this issue Nov 23, 2016 · 1 comment
Closed

Indicate if field is optional #12458

normalser opened this issue Nov 23, 2016 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Milestone
TypeScript 2.7

Comments

@normalser
Copy link

Not sure if this is for vscode or TSServer so I will start here.

It would be great if intellisense could show (maybe ? icon) which fields are optional:

image
@DanielRosenwasser
Copy link
Member

See also #1411.

@mhegazy mhegazy added the Bug A bug in TypeScript label Nov 23, 2016
@mhegazy mhegazy assigned ghost Nov 23, 2016
@mhegazy mhegazy added this to the Future milestone Nov 23, 2016
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Dec 13, 2017
@mjbvz mjbvz mentioned this issue Dec 13, 2017
Closed
mjbvz added a commit to mjbvz/TypeScript that referenced this issue Dec 21, 2017
@mjbvz
Add kindModifier to mark if a completion item is for an optional field
47ad57b 
For microsoft#12458

Adds a new KindModifier for completion items to mark when a property is optional. This can be used by editors to either change the item icon or add a `?` to the item text
mjbvz added a commit to mjbvz/TypeScript that referenced this issue Dec 21, 2017
@mjbvz
Add kindModifier to mark if a completion item is for an optional field
8bb66fe 
For microsoft#12458

Adds a new KindModifier for completion items to mark when a property is optional. This can be used by editors to either change the item icon or add a `?` to the item text
@mjbvz mjbvz mentioned this issue Dec 21, 2017
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 5, 2018
@mhegazy mhegazy modified the milestones: Future, TypeScript 2.7 Jan 5, 2018
@mhegazy mhegazy closed this as completed Jan 5, 2018
mhegazy pushed a commit that referenced this issue Jan 5, 2018
@mjbvz @mhegazy
Add kindModifier to mark if a completion item is for an optional field (
12d5063 
#20839)

* Add kindModifier to mark if a completion item is for an optional field

For #12458

Adds a new KindModifier for completion items to mark when a property is optional. This can be used by editors to either change the item icon or add a `?` to the item text

* Add method test

* Baseline-accept
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
TypeScript 2.7
Development

No branches or pull requests
4 participants
@DanielRosenwasser @normalser @mhegazy @mjbvz