Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types for TransitionEvent object #13888

Closed
devversion opened this issue Feb 5, 2017 · 2 comments
Closed

Types for TransitionEvent object #13888

devversion opened this issue Feb 5, 2017 · 2 comments
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue

Comments

@devversion
Copy link
Contributor

TypeScript Version: Master

Code

/* propertyName and elapsedTime are variables above. */
let event = new TransitionEvent('transitionend', {propertyName, elapsedTime});

As per the definition of the TransitionEvent object, there are no parameters supported (See here)

Expected behavior:

As specified in MDN, the TransitionEvent has a different constructor signature and should accept a type and an options object.

Here is the MDN artice: https://developer.mozilla.org/en-US/docs/Web/API/TransitionEvent/TransitionEvent

Also confirmed that this works the same way in Chrome right now.

Actual behavior:

TypeScript currently only allows us to create a TransitionEvent without any parameters.

Would like to submit a PR if desired and if bug is valid.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 6, 2017

Should be fixed by #13856

@mhegazy mhegazy added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue labels Feb 6, 2017
@mhegazy mhegazy added this to the TypeScript 2.2.1 milestone Feb 6, 2017
@mhegazy mhegazy closed this as completed Feb 6, 2017
@devversion
Copy link
Contributor Author

@mhegazy Cool. Thanks!

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants