-
Notifications
You must be signed in to change notification settings - Fork 12.8k
typescriptServices.d.ts no longer works without CommonJS #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The code below seems to work (I did it in a file called test.ts) and compiled it with
Hope it helps! :) edit: |
Is that based on compiling the very latest code in the master branch? (not the LKG) |
My code is all here btw: |
Ok, I think I see what you mean now - this works with CommonJS modules. Hmm, my code isn't currently using CommonJS though - perhaps CommonsJS is now required? |
My example is with the latest master (98750ca). From what I see in the bridge Gruntfile.js, you are concattening the typescript code with your own code, so you don't want to "require" the file. In that case It might be easier to just remove the Another way: |
Cool, thanks for the suggestions (the browserify idea is really cool!). I'll definitely do one of those options if its intentional to no longer support consumption of the definition file without using modules. |
Should be fixed in #1417. We'll be bringing that into master shortly. |
The new typescriptServices.d.ts file is great! Looks like a lot of stuff was cleaned up and some comments were added - thanks! |
I'm attempting to update the TypeScript language services from master but I'm hitting errors that look like this:
It looks like this is being caused by this new line in typescriptServices.d.ts:
If I remove this line, references like "ts.Classifier" work once again. With it, I'm not able to reference the classifier either with or without the "ts." prefix. Is there another way to reference things like the classifier that I should use instead?
The text was updated successfully, but these errors were encountered: