Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add insertSpaceAfterTypeAssertion Formatting Option to TSServer Protocol #14661

Closed
mjbvz opened this issue Mar 14, 2017 · 3 comments
Closed

Add insertSpaceAfterTypeAssertion Formatting Option to TSServer Protocol #14661

mjbvz opened this issue Mar 14, 2017 · 3 comments
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Milestone
TypeScript 2.4

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 14, 2017

#10402 added a insertSpaceAfterTypeAssertion formatting setting. We'd like this exposed in the TSServer protocol so that users can configure it in VSCode: microsoft/vscode#10296
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Mar 14, 2017
@mjbvz mjbvz mentioned this issue Mar 14, 2017
Closed
@csentis
Copy link

csentis commented May 12, 2017

Could someone kindly pick this up? It has been a blocker for VScode to autoformat TS appropriately since August last year. Thanks greatly!

@mhegazy mhegazy self-assigned this May 12, 2017
@mhegazy mhegazy added the Bug A bug in TypeScript label May 12, 2017
@mhegazy mhegazy mentioned this issue May 12, 2017
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label May 12, 2017
@mhegazy mhegazy added this to the TypeScript 2.4 milestone May 12, 2017
@mhegazy
Copy link
Contributor

mhegazy commented May 12, 2017

Sorry for the delay, fell off my list.

@lucap86
Copy link

lucap86 commented Jun 7, 2017 •
edited
Loading

@mhegazy insertSpaceAfterTypeAssertion doesn't work with sintax <MyType>(a||b)

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
TypeScript 2.4
Development

No branches or pull requests
4 participants
@mhegazy @csentis @mjbvz @lucap86