"Format Code" causes tslint failure with type assertions

[egamma]

From @LOZORD on August 5, 2016 3:14

If I have code like this:

const bar = <Bar> Thing.getFoo();

and then "Format Code" (alt-shift-F on Mac), I get this:

const bar = <Bar>Thing.getFoo();

The missing space after the closing angled bracket causes a spacing failure with tslint. I removed the settings in my .vscode/settings.json that have to do with JS/TS spacing, and the error still occurred. Is there something else I can configure to solve this?

Copied from original issue: Microsoft/vscode-tslint#69

[egamma]

Format Code is provided by vscode. Moving the issue to vscode.

[dbaeumer]

@egamma the error @LOZORD complains about comes from tslint. I am not sure what VS Code should do about this expect filing a feature request to TS to support an option to have a space after a cast operator.

[LOZORD]

I guess the easiest fix might just be to not include the check-typecast rule under whitespace in tslint.json 😕

[egamma]

@dbaeumer agreed, this is really a feature request for the TS formatter to support an option to have a space after a cast operator.

[LOZORD]

So how should I/we proceed?

[dbaeumer]

@LOZORD best is to open a feature request for the formatter here: https://github.com/Microsoft/typescript

[csentis]

Could someone please let me know how to activate this in vscode? I do not get the expected results when putting this into my settings:

"typescript.format.insertSpaceAfterTypeAssertion": true

[dbaeumer]

@mjbvz is this support already. Looks like TS merged a PR for this but we don't have a setting for this yet in VS Code.

[mjbvz]

This formatting option doesn't seem to be in the TSServer protocol yet. Adding it is being tracked by microsoft/TypeScript#14661

[lucap86]

@csentis
a quickFix as we wait for this feature is added

clone typescript repo in ad folder (i will call it FOLDER)
link -> https://github.com/Microsoft/TypeScript/archive/master.zip
than add

insertSpaceAfterTypeAssertion: true,

in FOLDER/lib/tsserver.js at line 68794
than in vscode settings

"typescript.format.insertSpaceAfterTypeAssertion": true,
"typescript.tsdk": "PATH_TO_FOLDER/lib/",

restart vscode

Note: recall to restore typescript.tsdk rule when tsserver will be updated

[mjbvz]

This should be in TS 2.4: microsoft/TypeScript#14661

Added to the June plan

[csentis]

@mjbvz if I read the June Iteration Plan properly, this has been deferred. Can you correct me?

[mjbvz]

@csentis Thanks for the reminder. This should be in for June with TS 2.4

[csentis]

@mjbvz Thank YOU

[roblourens]

@mjbvz with TS 2.4.1, "typescript.format.insertSpaceAfterTypeAssertion": true is an "unknown config setting" and it still removes the space when formatting. Am I doing something wrong?

[mjbvz]

@roblourens The change went in pretty recently and isn't in the current insiders build. Can you try a build from master? The next insiders should also have this change

[roblourens]

Oops, didn't notice the timestamp

[chrmarti]

Verified the setting exists and works as expected.