Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uint8ClampedArray#set(array,offset) #15275

Closed
reiner-dolp opened this issue Apr 19, 2017 · 0 comments
Closed

Uint8ClampedArray#set(array,offset) #15275

reiner-dolp opened this issue Apr 19, 2017 · 0 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this

Comments

@reiner-dolp
Copy link
Contributor

reiner-dolp commented Apr 19, 2017

Uint8ClampedArray defines its set method as follows:

     /**
      * Sets a value or an array of values.
      * @param array A typed or untyped array of values to set.
      * @param offset The index in the current array at which the values are to be written.
      */
    set(array: Uint8ClampedArray, offset?: number): void;

All other typed array variants (Uint8Array, Float32Array, ...) define their implementation as follows:

set(array: ArrayLike<number>, offset?: number): void;

Is this a bug? I could not find a reason for this in the spec. Especially given the doc-comment A typed or untyped array of values to set this seems to be a typo.

@RyanCavanaugh RyanCavanaugh added Help Wanted You can do this Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Apr 19, 2017
@mhegazy mhegazy added this to the Community milestone Apr 19, 2017
@mhegazy mhegazy modified the milestones: TypeScript 2.3.1, Community Apr 19, 2017
mhegazy added a commit that referenced this issue Apr 19, 2017
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 19, 2017
@mhegazy mhegazy closed this as completed Apr 19, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

3 participants