Skip to content

VS 2015 Preview language service not recognize --module (TypeScriptModuleKing) flag #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flaticols opened this issue Jan 5, 2015 · 6 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Needs More Info The issue still hasn't been fully clarified Visual Studio Integration with Visual Studio

Comments

@flaticols
Copy link

Hi!

I'm build TypeScript from 4e5a3ae commit and release-1.4 branch. After this. in VS where use export keyword for modules . classes and etc. Visual Studio highlight as error
Cannot compile external modules unless the '--module' flag is provided

But it's compiled well fine.

Examples:

export module Foo {}
module Foo {}
export = Foo;

In project file "TypeScriptModuleKind" property set as "commonjs" or "amd".

@ctaggart
Copy link
Contributor

ctaggart commented Jan 8, 2015

I'm blocked by this issue. I'm using the latest from master with Visual Studio 2015 Preview.

image

The module system is set to CommonJS:

image

image

Here are the steps I did:

git pull
jake LKG
npm install -g
explorer built\local
  • copy typescriptServices.js to
    C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\CommonExtensions\Microsoft\TypeScript

@ctaggart
Copy link
Contributor

ctaggart commented Jan 8, 2015

I forgot to update the tsc.js to C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.1, so I was getting the error when building too. This is no longer blocking me, but still pops up as an error in Error List.

@flaticols
Copy link
Author

@ctaggart yeap. But

still pops up as an error in Error List

And this is a problem.

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Visual Studio Integration with Visual Studio labels Jan 8, 2015
@sophiajt sophiajt added this to the TypeScript 1.4 milestone Jan 12, 2015
@mhegazy mhegazy modified the milestones: TypeScript 1.4, TypeScript 1.4.1 Jan 14, 2015
@mhegazy mhegazy added the Needs More Info The issue still hasn't been fully clarified label Jan 21, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Feb 3, 2015

Can you give this a try on TypeScript 1.4 release?

@mhegazy mhegazy closed this as completed Feb 5, 2015
@flaticols
Copy link
Author

In 1.4 it's works

@mhegazy
Copy link
Contributor

mhegazy commented Feb 9, 2015

thanks @flaticols

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Feb 9, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Needs More Info The issue still hasn't been fully clarified Visual Studio Integration with Visual Studio
Projects
None yet
Development

No branches or pull requests

5 participants