Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strictNullChecks fails to prevent undefined assignments #17236

Closed
start opened this issue Jul 16, 2017 · 3 comments
Closed

strictNullChecks fails to prevent undefined assignments #17236

start opened this issue Jul 16, 2017 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@start
Copy link

start commented Jul 16, 2017

TypeScript Version: 2.4.0 / nightly (2.5.0-dev.201xxxxx)

This example currently compiles in the TypeScript playground with strictNullChecks enabled.

Code

With strictNullChecks enabled:

class Widget {
  price: number

  // This example compiles with and without a constructor
  constructor() { }
}

const widget = new Widget()
const somePrice: number = widget.price

Expected behavior:

I expect a compilation error. Widget's price field is not nullable, but every constructed widget will have an undefined price.

The constructor should ensure price is non-null.

Actual behavior:

The code compiles. Two non-nullable numbers are set to undefined: somePrice and widget.price.

P.S. I'm in love with TypeScript. Thank you for your amazing work!

@RyanCavanaugh
Copy link
Member

Duplicate of #8476

@RyanCavanaugh RyanCavanaugh marked this as a duplicate of #8476 Jul 16, 2017
@RyanCavanaugh RyanCavanaugh added the Duplicate An existing issue was already created label Jul 16, 2017
start added a commit to start/up that referenced this issue Jul 16, 2017
To be honest, TypeScript shouldn't have allowed the field to be
non-nullable to begin with.

Please see:

microsoft/TypeScript#17236
@start
Copy link
Author

start commented Jul 16, 2017

Oops. Sorry about that!

@mhegazy
Copy link
Contributor

mhegazy commented Aug 17, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Aug 17, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants