Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: infer type predicates #17924

Closed
pelotom opened this issue Aug 19, 2017 · 3 comments
Closed

Feature request: infer type predicates #17924

pelotom opened this issue Aug 19, 2017 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@pelotom
Copy link

pelotom commented Aug 19, 2017

TypeScript Version: 2.4.2

It would be really nice if certain boolean-returning functions could be inferred to be type predicates. For example, in RxJS one of the signatures for the filter method is

function filter<T, S extends T>(
  this: Observable<T>,
  predicate: (value: T, index: number) => value is S,
  thisArg?: any
): Observable<S>;

It's very useful to filter on an observable and thereby have the resulting observable's type be refined:

type Action =
  | { type: 'FOO'; fooField: number }
  | { type: 'BAR'; barField: string }

action$
  .filter(action => action.type === 'FOO')
  .mergeMap(({ fooField }) => ...)

however this won't work because the lambda action => action.type === 'FOO' is not inferred to have the type (action: Action) => action is { type: 'FOO'; fooField: number }, even though the compiler should know this is true.

@aluanhaddad
Copy link
Contributor

See also #12798

@mhegazy
Copy link
Contributor

mhegazy commented Aug 22, 2017

Duplicate of #5101, #14891. Please see #5101 (comment) for more details. if you do have a proposal in mind on how this can be accomplished for the general case feel free to post it to #5101.

@mhegazy mhegazy added the Duplicate An existing issue was already created label Aug 22, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Sep 5, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Sep 5, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants