Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSServer --globalPlugins not working for inferred projects #18322

Closed
mjbvz opened this issue Sep 7, 2017 · 4 comments
Closed

TSServer --globalPlugins not working for inferred projects #18322

mjbvz opened this issue Sep 7, 2017 · 4 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Sep 7, 2017

TypeScript Version: 2.5.2

Steps to reproduce
In a folder with no tsconfig or jsconfig and a single ts file

Start the tsserver with --globalPlugins ts-css-plugin --pluginProbeLocations /Users/matb/projects/css-template-plugin

Bug
I don't see the plugin being loaded unless I create an empty tsconfig.json file

@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Sep 7, 2017
@mjbvz mjbvz changed the title TSServer --globalPlugins not working inferred projects TSServer --globalPlugins not working for inferred projects Sep 7, 2017
@mhegazy mhegazy added the Bug A bug in TypeScript label Sep 9, 2017
@mhegazy mhegazy added this to the TypeScript 2.6 milestone Sep 9, 2017
@RyanCavanaugh
Copy link
Member

@mjbvz I have a tentative fix up at https://github.com/RyanCavanaugh/TypeScript/tree/fix18322 but I'm not sure how to test it. Can you give it a spin or provide some user-side instructions?

@mjbvz
Copy link
Contributor Author

mjbvz commented Oct 19, 2017

Try installing this vscode extension: https://github.com/mjbvz/vscode-styled-components-extension by manually installing the vsix from the repo

Make sure you are using VSCode's version of typescript. We currently disable global plugins if you use the workspace versions

@mjbvz
Copy link
Contributor Author

mjbvz commented Nov 10, 2017

@RyanCavanaugh I don't see this working properly in VS Code 1.18 with TS 2.6.1.

To test:

  1. In VS Code 1.18, install the vsix from this repo
  2. Open a empty folder in VS Code
  3. Create a single ts file with the contents:
styled`

`
  1. Try requesting completions inside of the template string

I do not see any css completions. However after creating a tsconfig.json—even without setting the plugins—I start seeing the expected css completions

@anstarovoyt
Copy link

starting from WS2017.3 we use ts-plugin for providing the Angular LS support in WebStorm and the issue also affects us. Rel. https://youtrack.jetbrains.com/issue/WEB-30045

mjbvz added a commit to mjbvz/TypeScript that referenced this issue Dec 22, 2017
Fixes microsoft#18322

Ensure that we also try to load global plugins for inferred projects. Moves global plugin loading logic to base `Project` class from `ConfigureProject` .
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 4, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

4 participants