-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSServer --globalPlugins not working for inferred projects #18322
Comments
@mjbvz I have a tentative fix up at https://github.com/RyanCavanaugh/TypeScript/tree/fix18322 but I'm not sure how to test it. Can you give it a spin or provide some user-side instructions? |
Try installing this vscode extension: https://github.com/mjbvz/vscode-styled-components-extension by manually installing the vsix from the repo Make sure you are using VSCode's version of typescript. We currently disable global plugins if you use the workspace versions |
@RyanCavanaugh I don't see this working properly in VS Code 1.18 with TS 2.6.1. To test:
I do not see any css completions. However after creating a |
starting from WS2017.3 we use ts-plugin for providing the Angular LS support in WebStorm and the issue also affects us. Rel. https://youtrack.jetbrains.com/issue/WEB-30045 |
Fixes microsoft#18322 Ensure that we also try to load global plugins for inferred projects. Moves global plugin loading logic to base `Project` class from `ConfigureProject` .
TypeScript Version: 2.5.2
Steps to reproduce
In a folder with no
tsconfig
orjsconfig
and a single ts fileStart the tsserver with
--globalPlugins ts-css-plugin --pluginProbeLocations /Users/matb/projects/css-template-plugin
Bug
I don't see the plugin being loaded unless I create an empty
tsconfig.json
fileThe text was updated successfully, but these errors were encountered: