TSServer plugins pointing to relative paths are not loaded in 2.5

[mjbvz]

Steps to Reproduce:

1. Create a tsconfig.json

{
  "compilerOptions": {
    "target": "es2015",
    "module": "commonjs",
    "plugins": [
      { "name": "./lib" }
    ]
  }
}

Where a typescript server plugin in installed at lib.

2. Open the workspace in an editor

Bug
Plugin is not loaded. This works in TS 2.4.2 but is broken in TS 2.5.x

This is a useful configuration for testing a plugin

[mhegazy]

@Andy-MS can you take a look at this?

[mhegazy]

if we can get a fix for it we should put it in 2.5.3

This doesn't seem to work for me in 2.4.2? Here's the relevant tsserver log output:

Info 11   Loading ./lib from C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js/../../.. (resolved to C:/Users/anhans/AppData/Roaming/npm/node_modules/node_modules)
Info 12   Failed to load module: {}
Info 13   Loading ./lib from  (resolved to c:/Users/anhans/work/sample/zzz/node_modules)
Info 14   Failed to load module: {}
Info 15   Couldn't find ./lib anywhere in paths: C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js/../../..,

The plugin is in ./lib relative to your project's tsconfig.json, right? It looks like it's looking relative to its installation directory instead.

The tsserver log in typescript@next fails in the same way, although with a different error message:

Info 11   [7:41:53.402] Enabling plugin ./lib from candidate paths: C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js/../../..
Info 12   [7:41:53.402] Loading ./lib from C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js/../../.. (resolved to C:/Users/anhans/AppData/Roaming/npm/node_modules/node_modules)
Info 13   [7:41:53.412] Failed to load module './lib': Error: Could not resolve JS module './lib' starting at 'C:/Users/anhans/AppData/Roaming/npm/node_modules/node_modules'. Looked in: C:/Users/anhans/AppData/Roaming/npm/node_modules/node_modules/lib.js, C:/Users/anhans/AppData/Roaming/npm/node_modules/node_modules/lib.jsx, C:/Users/anhans/AppData/Roaming/npm/node_modules/node_modules/lib/package.json, C:/Users/anhans/AppData/Roaming/npm/node_modules/node_modules/lib/index.js, C:/Users/anhans/AppData/Roaming/npm/node_modules/node_modules/lib/index.jsx
    at Object.resolveJavaScriptModule (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:5058:19)
    at Object.sys.require (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:85025:45)
    at Function.Project.resolveModule (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:79747:35)
    at ConfiguredProject.enablePlugin (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:80409:50)
    at ConfiguredProject.enablePlugins (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:80382:30)
    at new ConfiguredProject (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:80360:23)
    at ProjectService.createAndAddConfiguredProject (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:81366:31)
    at ProjectService.openConfigFile (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:81410:36)
    at ProjectService.openOrUpdateConfiguredProjectForFile (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:81178:35)
    at ProjectService.openClientFileWithNormalizedPath (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:81690:32)
    at IOSession.Session.openClientFile (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:83010:46)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:82238:31)
    at C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:83626:88
    at IOSession.Session.executeWithRequestId (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:83617:28)
    at IOSession.Session.executeCommand (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:83626:33)
    at IOSession.Session.onMessage (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:83646:35)
    at Interface.<anonymous> (C:\Users\anhans\AppData\Roaming\npm\node_modules\typescript\lib\tsserver.js:84793:27)
    at emitOne (events.js:96:13)
    at Interface.emit (events.js:191:7)
    at Interface._onLine (readline.js:241:10)
    at Interface._normalWrite (readline.js:384:12)
    at Socket.ondata (readline.js:101:10)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:191:7)
    at readableAddChunk (_stream_readable.js:178:18)
    at Socket.Readable.push (_stream_readable.js:136:10)
    at Pipe.onread (net.js:560:20)
Info 14   [7:41:53.412] Couldn't find ./lib

@weswigham may know something about whether this was ever intended to work.

[mjbvz]

Here's an example that was using the config: https://github.com/Quramy/ts-graphql-plugin/blob/master/e2e/project-fixture/tsconfig.json

I'm not sure if that path is relative to the tsconfig or to the typescript install

[weswigham]

@mjbvz Since each member of the plugins map is not a top-level element or compiler flag marked as a file path; it is going to get resolved relative to the base directory of the compilation, similarly to how the paths, or typeRoots arguments' members should.

Regarding the loading of the plugin, cc @RyanCavanaugh, who should know more on the behavior of the loader.

[mjbvz]

I was able to work around this in my plugin tests by creating a npm install of a local package. Not sure restoring the path based plugin loading behavior is correct