Cannot read property 'flags' of undefined #19142

ghost · 2017-10-12T21:36:54Z

Been dealing with this for months, please fix.

./src/app/auth/auth.manager.ts
Module build failed: TypeError: Cannot read property 'flags' of undefined
    at resolveAlias (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:28064:36)
    at checkAliasSymbol (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46447:26)
    at checkImportBinding (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46477:13)
    at Object.forEach (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:1506:30)
    at checkImportDeclaration (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46498:32)
    at checkSourceElement (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46789:28)
    at Object.forEach (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:1506:30)
    at checkSourceFileWorker (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46862:20)
    at checkSourceFile (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46842:13)
    at getDiagnosticsWorker (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46906:17)
    at getDiagnostics (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46892:24)
    at Object.getEmitResolver (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:27162:13)
    at C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:70021:69
    at runWithCancellationToken (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:69779:24)
    at getDeclarationDiagnosticsForFileNoCache (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:70020:20)
    at getAndCacheDiagnostics (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:70033:26)
 @ ./src/app/core/core.module.ts 19:0-51
 @ ./src/app/app.module.ts
 @ ./src/main.ts
 @ multi webpack-dev-server/client?http://localhost:9090 ./src/main.ts

The text was updated successfully, but these errors were encountered:

mhegazy · 2017-10-13T00:22:34Z

what version are you seeing this on? have you tried on typescript@next? what is the source code that is causing this issue to happen?

ghost · 2017-10-13T00:28:34Z

I wish I knew!! I promise I would provide more if I knew more. I'll try "@next" tomorrow, no sweat. Is there a way to get to compiler to print out more information about the code it's working on? This could be way after tokenizing and syntax checking so I don't know. I have been seeing this for months, it happens only using HRM (already set timeout to 2 seconds so it's not an file-system race condition). I feel like something changed in my code style-wise and it started appearing. Missing @component{ styleUrls: [] } maybe?

…

On Thu, Oct 12, 2017 at 5:23 PM, Mohamed Hegazy ***@***.***> wrote: what version are you seeing this on? have you tried on ***@***.***? what is the source code that is causing this issue to happen? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19142 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX5Xbob0PNbEhm5ZODo5jIbUomh6P1wQks5srq1vgaJpZM4P3qob> .

-- CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. It is then shared with tech companies, bots, hackers, government agencies, and marketers. The security of this message is none, and it may be shared on Instagram at anytime. If you are OK with this, please respond. There isn't really any security or privacy anywhere. If you disagree you may want to go camping and talk to people face-to-face like in old times.

mhegazy · 2017-10-14T00:41:58Z

We would be happy to sign any required NDA to get access to the code. you can also email me directly a sample that reproduces the issue on my github username @microsoft.com.

mhegazy · 2017-10-16T16:12:03Z

You can email me the zip file.

mhegazy · 2017-10-16T16:13:00Z

You can also launch the compiler under node inspector, assuming you have node v7 or later

node --inspect --debug-brk node_modules\typescript\lib\tsc.js --p <path to your tsconfig.json>

in your chrome go to chrome://inspect. let the process run, when it breaks, there should be getSemanticDiagnosticsForFileNoCache on the stack. Look up the value of sourceFile.fileName in your watch window, this should tell you which file is causing the issue. you can also dump the diagnostic object that is the argument of the function.

ghost · 2017-10-16T16:40:24Z

Hmm, I am not sure how to do that from within the angular-cli serve command, but --inspect is definitely an interesting flag.

…

On Mon, Oct 16, 2017 at 9:14 AM, Mohamed Hegazy ***@***.***> wrote: You can also launch the compiler under node inspector, assuming you have node v7 or later node --inspect --debug-brk node_modules\typescript\lib\tsc.js --p <path to your tsconfig.json> in your chrome go to chrome://inspect. let the process run, when it breaks, there should be getSemanticDiagnosticsForFileNoCache on the stack. Look up the value of sourceFile.fileName in your watch window, this should tell you which file is causing the issue. you can also dump the diagnostic object that is the argument of the function. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19142 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX5Xbjv9j22GCSvGtb4nwrrejxnZXHWZks5ss4D7gaJpZM4P3qob> .

-- CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. It is then shared with tech companies, bots, hackers, government agencies, and marketers. The security of this message is none, and it may be shared on Instagram at anytime. If you are OK with this, please respond. There isn't really any security or privacy anywhere. If you disagree you may want to go camping and talk to people face-to-face like in old times.

ghost · 2017-10-16T16:40:44Z

Any ideas @filipesilva ?

filipesilva · 2017-10-16T16:47:30Z

@megamindbrian this looks like a bug with one of the transforms we use in Angular CLI. Impossible to tell what's happening just from the log though. Can you open an issue on https://github.com/angular/angular-cli and include a reproduction of what I can do to see the error myself?

Meanwhile if you want to inspect the error you can use the following command: node --inspect --debug-brk ./node_modules/@angular/cli/bin/ng serve.

ghost · 2017-10-16T16:48:23Z

Perfect, thank you! This is gold. I didn't even know this was possible.

ghost · 2017-10-16T16:54:11Z

Cool, just got it to fail in the debugger. Looks like if you are editing a file in watch mode, and you create something invalid like <new line> alert with no semi-colon. Save. Edit, and remove the line alert.
Watch never recovers from errors and just displays this flags error.

filipesilva · 2017-10-16T17:03:10Z

Awesome, that's definitely not intended. Please include that reproduction in the CLI issue, together with the other details. Angular and TS versions are especially important because we use different pipeline depending on those.

ghost · 2017-10-16T17:07:14Z

I got it to break in the typescript compiler on an Injectable token, but I am not sure what file or anything unusual that is causing it:

I'll probably hunt around a bit and then try some different versions. Thank you for the good starting point!

RyanCavanaugh · 2017-10-16T17:08:30Z

@megamindbrian running ts.getTextOfNode(node) ts.getTextOfNode(node.parent) at that point in the debugger's console window should tell you the offending node

RyanCavanaugh · 2017-10-16T17:10:05Z

(You can keep adding .parent until the entire node context becomes obvious)

ghost · 2017-10-16T17:11:33Z

@RyanCavanaugh Yeah, I dropped down to getDiagnostics(), and it was just the same file that I edited erroneously. Maybe watch doesn't recover on Injectables because there is no configuration options? Injectable() takes 0 arguments? I am trying typescript@next now. I haven't updated Angular 4 in a while (~ a least a month).

ghost · 2017-10-16T17:26:40Z

Confirmed this Module build failed: TypeError: Cannot read property 'flags' of undefined
error only occurs (for me) when a mistake is made in an Injectable, and then corrected. Watch mode doesn't recover on that specific file until another correct change is made.

mhegazy · 2017-10-16T18:30:54Z

can you get us a small sample that makes it crash?

ghost · 2017-10-16T18:47:03Z

I was on my way to doing just that, but setting up a new project the error goes away. Line numbers with the invalid line work just fine. This is using typescript@next with angular 4.4.0. Trying to upgrade my current project to angular 4.4 to see if it still happens.

…

On Mon, Oct 16, 2017 at 11:33 AM, Mohamed Hegazy ***@***.***> wrote: can you get us a small sample that makes it crash? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19142 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AX5XbqSeGe0t71a4-2cjUjCgm0dLo0Tjks5ss6FfgaJpZM4P3qob> .

-- CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. It is then shared with tech companies, bots, hackers, government agencies, and marketers. The security of this message is none, and it may be shared on Instagram at anytime. If you are OK with this, please respond. There isn't really any security or privacy anywhere. If you disagree you may want to go camping and talk to people face-to-face like in old times.

ghost · 2017-10-16T19:42:44Z

Been debugging the entire code base with no errors using Typescript "^>=2.1.0 <2.4.0" and Angular 4.4.5 no "flags" error. On Mon, Oct 16, 2017 at 11:46 AM, Brian Cullinan <megamindbrian@gmail.com> wrote:

…

I was on my way to doing just that, but setting up a new project the error goes away. Line numbers with the invalid line work just fine. This is using ***@***.*** with angular 4.4.0. Trying to upgrade my current project to angular 4.4 to see if it still happens. On Mon, Oct 16, 2017 at 11:33 AM, Mohamed Hegazy ***@***.*** > wrote: > can you get us a small sample that makes it crash? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#19142 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AX5XbqSeGe0t71a4-2cjUjCgm0dLo0Tjks5ss6FfgaJpZM4P3qob> > . > -- CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. It is then shared with tech companies, bots, hackers, government agencies, and marketers. The security of this message is none, and it may be shared on Instagram at anytime. If you are OK with this, please respond. There isn't really any security or privacy anywhere. If you disagree you may want to go camping and talk to people face-to-face like in old times.

-- CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. It is then shared with tech companies, bots, hackers, government agencies, and marketers. The security of this message is none, and it may be shared on Instagram at anytime. If you are OK with this, please respond. There isn't really any security or privacy anywhere. If you disagree you may want to go camping and talk to people face-to-face like in old times.

mhegazy · 2017-10-30T23:46:16Z

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

lddubeau · 2017-11-02T20:40:00Z

As megamindbrian's last comment suggests, switching TypeScript versions may be enough to fix the issue. I had it with TS 2.4. It went away after switching to TS 2.6.

mhegazy added the Needs More Info The issue still hasn't been fully clarified label Oct 13, 2017

mhegazy closed this as completed Oct 30, 2017

microsoft locked and limited conversation to collaborators Jun 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot read property 'flags' of undefined #19142

Cannot read property 'flags' of undefined #19142

ghost commented Oct 12, 2017

mhegazy commented Oct 13, 2017

ghost commented Oct 13, 2017 via email

mhegazy commented Oct 14, 2017

mhegazy commented Oct 16, 2017

mhegazy commented Oct 16, 2017

ghost commented Oct 16, 2017 via email

ghost commented Oct 16, 2017

filipesilva commented Oct 16, 2017 •

edited

Loading

ghost commented Oct 16, 2017 •

edited by ghost

Loading

ghost commented Oct 16, 2017

filipesilva commented Oct 16, 2017

ghost commented Oct 16, 2017

RyanCavanaugh commented Oct 16, 2017

RyanCavanaugh commented Oct 16, 2017 •

edited

Loading

ghost commented Oct 16, 2017 •

edited by ghost

Loading

ghost commented Oct 16, 2017 •

edited by ghost

Loading

mhegazy commented Oct 16, 2017

ghost commented Oct 16, 2017 via email

ghost commented Oct 16, 2017 via email

mhegazy commented Oct 30, 2017

lddubeau commented Nov 2, 2017

Cannot read property 'flags' of undefined #19142

Cannot read property 'flags' of undefined #19142

Comments

ghost commented Oct 12, 2017

mhegazy commented Oct 13, 2017

ghost commented Oct 13, 2017 via email

mhegazy commented Oct 14, 2017

mhegazy commented Oct 16, 2017

mhegazy commented Oct 16, 2017

ghost commented Oct 16, 2017 via email

ghost commented Oct 16, 2017

filipesilva commented Oct 16, 2017 • edited Loading

ghost commented Oct 16, 2017 • edited by ghost Loading

ghost commented Oct 16, 2017

filipesilva commented Oct 16, 2017

ghost commented Oct 16, 2017

RyanCavanaugh commented Oct 16, 2017

RyanCavanaugh commented Oct 16, 2017 • edited Loading

ghost commented Oct 16, 2017 • edited by ghost Loading

ghost commented Oct 16, 2017 • edited by ghost Loading

mhegazy commented Oct 16, 2017

ghost commented Oct 16, 2017 via email

ghost commented Oct 16, 2017 via email

mhegazy commented Oct 30, 2017

lddubeau commented Nov 2, 2017

filipesilva commented Oct 16, 2017 •

edited

Loading

ghost commented Oct 16, 2017 •

edited by ghost

Loading

RyanCavanaugh commented Oct 16, 2017 •

edited

Loading

ghost commented Oct 16, 2017 •

edited by ghost

Loading

ghost commented Oct 16, 2017 •

edited by ghost

Loading