TS auto import should support configuring whether a star or a qualified import is used.

[mjbvz]

From @dbaeumer on October 31, 2017 11:29

Testing: #37177

• vscode source code opened in VS Code
• open a file that doesn't import 'vs/base/common/types'
• type isStringArray
• select the entry from code complete list
• the following import is inserted:

import { isStringArray } from 'vs/base/common/types';

However what I want in this case is

import * as Types from 'vs/base/common/types';

and the code should become Types.isStringArray

Would be cool if I can control this via a setting.

Copied from original issue: microsoft/vscode#37258

[mjbvz]

I think this one needs some thought. For example, what name should we use for * from X?

Maybe this would be better as a refactoring? Change named imports to namespace import. We could also do the other way around.
Otherwise we would double the size of the already enormous completion list.

For example, what name should we use for * from X?

Refactorings conveniently already come with a rename location.

[DanielRosenwasser]

Maybe this would be better as a refactoring?

See #19260

[dbaeumer]

Having that as a separate refactoring makes sense, nevertheless I would like to have this right in the first place and not me picking an entry from a completion list and then being forced to execute another refactorings. In another tool I worked on ( :-) ) we had a configuration comparable to this to control the import generation:

{
    module: 'vs/base/common/types',
    importType: ImportType.Star,
    identifier: 'Types'
}

Default would IMO still be a qualified import.

[mhegazy]

Default would IMO still be a qualified import.

you mean import *? curious why?

[dbaeumer]

@mhegazy sorry used wrong words. Default should be import { .... } from