Auto import inserts import into a comment

[mjbvz]

From @yume-chan on November 22, 2017 2:8

• VSCode Version: Code - Insiders 1.19.0-insider (d294b25, 2017-11-21T06:34:51.660Z)
• OS Version: Windows_NT x64 10.0.16299
• Extensions: Extensions are disabled

---

Steps to Reproduce:

1. Create a new folder
2. Open in Code
3. npm i @types/node
4. Create index.js
5. Type /// <reference types="node" />
6. Type setTimeout, select the auto import suggest.

Expected Result:

/// <reference types="node" />

import { setTimeout } from "timers";

setTimeout

Actual Result:

/// <reference types="node" />import { setTimeout } from "timers";



setTimeout

Copied from original issue: microsoft/vscode#38914

[mjbvz]

This is related to crlf line enedings. Here's the code action we get back for a crlf file:

 "codeActions": [
            {
                "description": "Import 'setTimeout' from \"timers\".",
                "changes": [
                    {
                        "fileName": "c:/source/test/y.js",
                        "textChanges": [
                            {
                                "start": {
                                    "line": 1,
                                    "offset": 33
                                },
                                "end": {
                                    "line": 1,
                                    "offset": 33
                                },
                                "newText": "import { setTimeout } from \"timers\";\r\n\r\n"
                            }
                        ]
                    }
                ]
            }
        ],

With lf line endings, we instead get:

 {
                "description": "Import 'setTimeout' from \"timers\".",
                "changes": [
                    {
                        "fileName": "/Users/matb/projects/san/index.js",
                        "textChanges": [
                            {
                                "start": {
                                    "line": 2,
                                    "offset": 1
                                },
                                "end": {
                                    "line": 2,
                                    "offset": 1
                                },
                                "newText": "import { setTimeout } from \"timers\";\n\n"
                            }
                        ]
                    }
                ]
            }
        ],

[mhegazy]

From #20292 (comment)

import { read } from "fs";

#!/usr/bin/env node

[ghost]

I'm not reproducing this with typescript@next on windows in a CRLF file.

[oliversalzburg]

The case that was quoted in #20293 (comment) appeared on my workstation.

That happened on Windows in a file with LF.

[weswigham]

I could swear that @amcasey mentioned noticing this (or something very like it) before and having a fix for it; Am I wrong?

[ghost]

I'm unable to reproduce either error (the original or the shebang one which should have been fixed by #20306) on windows in either an LF or CRLF file.