Skip to content

feat(es2018): add definitions for new array methods (flatten, flatMap) #20410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benbraou opened this issue Dec 3, 2017 · 3 comments
Closed

feat(es2018): add definitions for new array methods (flatten, flatMap) #20410

benbraou opened this issue Dec 3, 2017 · 3 comments
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Milestone
TypeScript 2.7

Comments

@benbraou
Copy link
Contributor

benbraou commented Dec 3, 2017

Array.prototype.flatMap and Array.prototype.flatten (https://github.com/tc39/proposal-flatMap) are now at stage 3

This issue is created to handle the addition of the corresponding definitions.

This has been suggested by @mhegazy #20385 (comment)
@benbraou
Copy link
Contributor Author

benbraou commented Dec 3, 2017

I will provide a PR for this

benbraou added a commit to benbraou/TypeScript that referenced this issue Dec 4, 2017
@benbraou
feat(es2018): add definitions for flatten and flatMap
0674fb6 
Fixes microsoft#20410
@benbraou benbraou mentioned this issue Dec 4, 2017
Merged
@mhegazy mhegazy added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Suggestion An idea for TypeScript Help Wanted You can do this Good First Issue Well scoped, documented and has the green light labels Dec 4, 2017
@mhegazy mhegazy added this to the Community milestone Dec 4, 2017
benbraou added a commit to benbraou/TypeScript that referenced this issue Dec 5, 2017
@benbraou
bug(esnext): add definitions for flatten and flatMap
fb50d9c 
Fixes microsoft#20410
@benbraou
Copy link
Contributor Author

benbraou commented Dec 5, 2017

Array.prototype.flatten and Array.prototype.flatMap will be marked for the moment as esnext and not es2018.
After TC39 January meeting, it will be clearer whether this will make it to es2018

benbraou added a commit to benbraou/TypeScript that referenced this issue Dec 6, 2017
@benbraou
bug(esnext): add definitions for flatten and flatMap
be2ae1d 
Fixes microsoft#20410
benbraou added a commit to benbraou/TypeScript that referenced this issue Dec 16, 2017
@benbraou
bug(esnext): add definitions for flatten and flatMap
8c2eeb2 
Fixes microsoft#20410
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.7 Jan 8, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 8, 2018
mhegazy pushed a commit that referenced this issue Jan 8, 2018
@benbraou @mhegazy
feat(es2018): add definitions for Array.prototype.flatten and Array.p…
804eb32 
…rototype.flatMap (#20431)

* bug(esnext): add definitions for flatten and flatMap

Fixes #20410

* bug(esnext) add overloads for flatten
@mhegazy
Copy link
Contributor

mhegazy commented Jan 8, 2018

thanks @benbraou!

@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 2.7
Development

No branches or pull requests
2 participants
@mhegazy @benbraou