Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose OutliningSpans as official TSServer API? #22133

Closed
mjbvz opened this issue Feb 22, 2018 · 0 comments
Closed

Expose OutliningSpans as official TSServer API? #22133

mjbvz opened this issue Feb 22, 2018 · 0 comments
Assignees
@mhegazy
Labels
API Relates to the public API for TypeScript Committed The team has roadmapped this issue Fixed A PR has been merged for this issue
Milestone
TypeScript 2.8

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 22, 2018

@aeschli is looking into language aware folding in vscode this iteration and we'd like to use theOutliningSpans TSServer API to implement this, however it is currently internal: https://github.com/Microsoft/TypeScript/blob/70e9a5e6dc02e5eb01e8dac3e0235a096b4d232f/src/server/protocol.ts#L91

Is this API ready for external usage?
@mjbvz mjbvz mentioned this issue Feb 23, 2018
Closed
@DanielRosenwasser DanielRosenwasser added API Relates to the public API for TypeScript Committed The team has roadmapped this issue labels Feb 23, 2018
@mhegazy mhegazy self-assigned this Feb 23, 2018
@mhegazy mhegazy added this to the TypeScript 2.8 milestone Feb 23, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 8, 2018
mhegazy added a commit that referenced this issue Mar 8, 2018
@mhegazy
Fix #22133: Expose getOutliningSpans on the server protocol
b111aec
@mhegazy mhegazy mentioned this issue Mar 8, 2018
Merged
mhegazy added a commit that referenced this issue Mar 9, 2018
@mhegazy
Fix #22133: Expose getOutliningSpans on the server protocol (#22400)
c335c38 
* Fix #22133: Expose getOutliningSpans on the server protocol

* Remove debugger statement from test
@mjbvz mjbvz mentioned this issue Mar 16, 2018
Closed
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
API Relates to the public API for TypeScript Committed The team has roadmapped this issue Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.8
Development

No branches or pull requests
3 participants
@DanielRosenwasser @mhegazy @mjbvz