-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(event: TouchEvent) => void is not assignable "touchstart" event. #22565
(event: TouchEvent) => void is not assignable "touchstart" event. #22565
Comments
Doesn't repro for me on latest. Are you passing any commandline flags as well? |
No, just running it normally after updating to the latest @next. |
we have the same errors in our project with 2.8. Steps to reproduce is very simple:
As result:
|
The reason of it is that typing of touch events changed in lib.dom.d.ts from TouchEvent to Event. |
PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes. |
Created a PR microsoft/TypeScript-DOM-lib-generator#394. This is a pretty big regression and it doesn't seem easy to work around. Feels like 2.8 shouldn't ship without a fix. |
@mhegazy as soon it is already fixed in tsjs repo, is it possible to include it in 2.8.2? |
TypeScript Version: 2.8.0-dev.20180314
Code
Expected behavior:
onTouchStart
should be treated as an event listener.Actual behavior:
Playground Link: link
Though the playground does not really demonstrate the issue, as it's not on the newest typescript version.
The text was updated successfully, but these errors were encountered: