Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding touch event typings #394

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Adding touch event typings #394

merged 3 commits into from
Mar 27, 2018

Conversation

jakearchibald
Copy link
Contributor

I'm not entirely sure what I'm doing, but if I've done this right it fixes microsoft/TypeScript#22565 - a regression created in #383 (comment).

@msftclas
Copy link

msftclas commented Mar 26, 2018

CLA assistant check
All CLA requirements met.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 26, 2018

you also need to include the new baselines. just run npm run baseline-accept after npm run build

Previously this wasn't copying anything, on OSX at least.
@jakearchibald
Copy link
Contributor Author

Done. I also fixed the baseline-accept script, which didn't do anything (on OSX at least).

@mhegazy mhegazy merged commit a8b2756 into microsoft:master Mar 27, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Mar 27, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(event: TouchEvent) => void is not assignable "touchstart" event.
3 participants