Skip to content

gulp VerifyLKG fails on case-sensitive file systems #23146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
evmar opened this issue Apr 4, 2018 · 1 comment · Fixed by #23844
Closed

gulp VerifyLKG fails on case-sensitive file systems #23146

evmar opened this issue Apr 4, 2018 · 1 comment · Fixed by #23844
Labels
Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure

Comments

@evmar
Copy link
Contributor

evmar commented Apr 4, 2018

TypeScript Version: e149641 (Friday March 30 2018)

Search Terms: gulp lkg pt-br

Code

$ gulp LKG
[...]
12:49:55] Error in plugin "run-sequence(VerifyLKG)"
Message:
    Cannot replace the LKG unless all built targets are present in directory built/local/. The following files are missing:
built/local/pt-BR/diagnosticMessages.generated.json
built/local/zh-CN/diagnosticMessages.generated.json
built/local/zh-TW/diagnosticMessages.generated.json

The missing files have the wrong case:

$ ls -d built/local/??-??
built/local/pt-br  built/local/zh-cn  built/local/zh-tw

The bug is here:
https://github.com/Microsoft/TypeScript/blob/0a7b7e07ee9cfae804baaf2bc2435b02e58964ce/scripts/generateLocalizedDiagnosticMessages.ts#L68

You shouldn't lowercase the locale.

Related Issues:

Maybe this one? @Andy-MS
#22084

The build instructions say to use gulp LKG so if you had guidance on whether to use gulp or jake I'd appreciate it.
@evmar evmar mentioned this issue Apr 4, 2018
Closed
@mhegazy
Copy link
Contributor

mhegazy commented Apr 4, 2018

@Andy-MS since you are running on Linux, can you take a look at #23146, #22084 and #23147

@mhegazy mhegazy added the Infrastructure Issue relates to TypeScript team infrastructure label Apr 4, 2018
@mhegazy mhegazy assigned ghost Apr 4, 2018
@ghost ghost mentioned this issue May 2, 2018
Merged
@ghost ghost added the Fixed A PR has been merged for this issue label May 2, 2018
@ghost ghost closed this as completed in #23844 May 3, 2018
mprobst added a commit to mprobst/TypeScript that referenced this issue Jun 21, 2018
@mprobst
Fix the build on case-sensitive file systems.
4b7208a 
Dashed locale names like `pt-BR` were misspelled as `pt-br` in several
locations.

This is a follow up fix to microsoft#23146.
@mprobst mprobst mentioned this issue Jun 21, 2018
Merged
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update LKG microsoft/TypeScript
2 participants
@evmar @mhegazy