Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomly get current identifier as completion #24009

Closed
ghost opened this issue May 9, 2018 · 1 comment
Closed

Randomly get current identifier as completion #24009

ghost opened this issue May 9, 2018 · 1 comment
Assignees
@sheetalkamat
Labels
Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Fixed A PR has been merged for this issue
Milestone
TypeScript 3.3

Comments

@ghost
Copy link

ghost commented May 9, 2018 •
edited by ghost
Loading

To reproduce:

  • Type namespace
  • Type randomly. Every once in a while, the current text will be recommended as a completion. I've gotten this to reproduce with const also.

May be a vscode bug. @mjbvz Any idea how this could happen?

werwke
@mhegazy mhegazy added the Bug A bug in TypeScript label Jul 12, 2018
@mhegazy mhegazy assigned ghost Jul 12, 2018
@mhegazy mhegazy added this to the TypeScript 3.1 milestone Jul 12, 2018
@mhegazy mhegazy added the Domain: Completion Lists The issue relates to showing completion lists in an editor label Jul 12, 2018
@ghost ghost modified the milestones: TypeScript 3.1, TypeScript 3.2 Sep 17, 2018
@ghost ghost assigned sheetalkamat and unassigned ghost Nov 16, 2018
@sheetalkamat sheetalkamat mentioned this issue Jan 3, 2019
Closed
@sheetalkamat
Copy link
Member

Moved the issue to vscode since tsserver correctly returns no completion info.

sheetalkamat added a commit that referenced this issue Jan 9, 2019
@sheetalkamat
Verify that completion with new identifier location returns isNewIden…
46482e1 
…tifierLocation: true

Fixes #24009

Signed-off-by: Sheetal Nandi <shkamat@microsoft.com>
@sheetalkamat sheetalkamat mentioned this issue Jan 9, 2019
Merged
@sheetalkamat sheetalkamat reopened this Jan 9, 2019
@sheetalkamat sheetalkamat added the Fixed A PR has been merged for this issue label Jan 9, 2019
errendir added a commit to errendir/TypeScript that referenced this issue Jan 14, 2019
@errendir
Merge remote-tracking branch 'origin/master' into debug-messages
a4c10a4 
* origin/master: (1082 commits)
  Fix unneeded cast lints (microsoft#29383)
  Extracted compilerOptions setting to helper function
  Added codefix to enable experimentalDecorators in the user's config file
  Add tests for noLib with <reference lib> and bundling.
  Add tests for noLib with <reference lib>.
  Do not process library reference directives with noLib set.
  emit jsx type arguments
  Allow circular umd-merged-with-augmentation refs to resolve to the module as intended (microsoft#29335)
  Allow nonnull assertions in references (microsoft#29351)
  Accept new baselines
  Add regression tests
  Improve logic that determines when to resolve conditional types
  Update user baselines (microsoft#29336)
  Fix crash (microsoft#29333)
  Exclude JSDoc @extends from 'super()' checks (microsoft#29308)
  Fix existing test
  Verify that completion with new identifier location returns isNewIdentifierLocation: true Fixes microsoft#24009
  Fix the failing test case
  There is no need to check for file presence when trying to rename imports based on file rename Fixes microsoft#29031
  Fix gulp baseline-accept (microsoft#29301)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sheetalkamat sheetalkamat

Labels
Bug A bug in TypeScript Domain: Completion Lists The issue relates to showing completion lists in an editor Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 3.3
Development

No branches or pull requests
3 participants
@DanielRosenwasser @mhegazy @sheetalkamat