Refactor to convert variable to destructuring

[ghost]

TypeScript Version: 3.1.0-dev.20180721

Code

function f() { return { x: 0, y: 1, z: 2 }; }
const p = f();
p.x;
p.y;
p.z;

Expected behavior:

After:

function f() { return { x: 0, y: 1, z: 2 }; }
const { x, y, z } = f();
x;
y;
z;

Note: I think it should generate { x, y, z } even if they're not all currently used (meaning, it should use every property declared in the return type of f). That way it's useful to perform this refactor immediately after writing the call to f(), before the result has been used.

Actual behavior:

No such refactor.

[DanielRosenwasser]

You probably want to be a little more careful here due to aliasing and assignment to p.x, p.y, or p.z.

[ghost]

If there's an assignment, we should probably not do the refactor -- let { x } = o; x = 2; does not mutate o as some might expect.

[RyanCavanaugh]

Declining due to low volume of feedback

[OliverJAsh]

The Abracadabra extension has tried to provide this refactoring but they've struggled to do it performantly—so I think there is definitely an appetite for this refactoring.