-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array mapped type change breaks ember array 'get' #26120
Comments
@andy-ms I can't repro on master - any additional details needed? |
@DanielRosenwasser Looks to me like we're doing the right thing here. You mentioned you'd discuss with the Ember folks. |
Fixes typed-ember/ember-cli-typescript#308 Workaround due to breaking change microsoft/TypeScript#26120 Would much much cleaner if this was fixed: microsoft/TypeScript#27014
- Fixes typed-ember/ember-cli-typescript#308 - Workaround due to breaking change microsoft/TypeScript#26120 - Would much much cleaner w/ a fix for microsoft/TypeScript#27014
- [x] Use a meaningful title for the pull request. Include the name of the package modified. - [x] Test the change in your own code. (Compile and run.) - [x] Add or edit tests to reflect the change. (Run with `npm test`.) - [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request). - [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes). - [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present). If changing an existing definition: - [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://www.emberjs.com/api/ember/3.4/functions/@ember%2Fobject/set - [x] Increase the version number in the header if appropriate. - [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ "extends": "dtslint/dt.json" }`. --- - Fixes typed-ember/ember-cli-typescript#308 - Workaround due to breaking change microsoft/TypeScript#26120 - Would much much cleaner w/ a fix for microsoft/TypeScript#27014
This issue has been marked as 'Question' and has seen no recent activity. It has been automatically closed for house-keeping purposes. If you're still waiting on a response, questions are usually better suited to stackoverflow. |
TypeScript Version: 3.1.0-dev.20180801
(works in 3.1.0-dev.20180731)
Code
Simplified from the compile error in
DefinitelyTyped/types/ember
:Expected behavior:
No error.
Actual behavior:
The intention was for the following type arguments to be inferred:
The code still works when the above type is explicitly provided.
I think this change is due to #26063 (CC @ahejlsberg).
The text was updated successfully, but these errors were encountered: