Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Service API review #2899

Closed
basarat opened this issue Apr 24, 2015 · 3 comments
Closed

Language Service API review #2899

basarat opened this issue Apr 24, 2015 · 3 comments
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it

Comments

@basarat
Copy link
Contributor

basarat commented Apr 24, 2015

I just updated to latest. Would like API equivalents for the following:

ts.typeToDisplayParts
ts.getTokenAtPosition
sourceFile.getNamedDeclarations

Error log:

/fixmyts/addClassMember.ts(5,31): error TS2305: Module '"typescript"' has no exported member 'typeToDisplayParts'.
/fixmyts/equalsToEquals.ts(5,31): error TS2305: Module '"typescript"' has no exported member 'typeToDisplayParts'.
/fixmyts/quoteToTemplate.ts(5,31): error TS2305: Module '"typescript"' has no exported member 'typeToDisplayParts'.
/fixmyts/quotesToQuotes.ts(5,31): error TS2305: Module '"typescript"' has no exported member 'typeToDisplayParts'.
/projectService.ts(736,38): error TS2339: Property 'getNamedDeclarations' does not exist on type 'SourceFile'.
/projectService.ts(922,36): error TS2339: Property 'getTokenAtPosition' does not exist on type 'typeof "typescript"'.
basarat added a commit to TypeStrong/atom-typescript that referenced this issue Apr 24, 2015
@mhegazy mhegazy added Bug A bug in TypeScript API Relates to the public API for TypeScript labels Apr 24, 2015
@basarat
Copy link
Contributor Author

basarat commented Apr 24, 2015

@mhegazy FWIW I don't need this anymore :) https://github.com/TypeStrong/atom-typescript/tree/master/lib/typescript but leaving it open as other people might need it.

Worth mentioning "../compiler/diagnosticInformationMap.generated.ts", needs to be in output js before "../compiler/commandLineParser.ts", but is listed in reverse in tsconfig.json. As mentioned previously here the order of files in the presence of out is significant and in this case it is wrong .. just thought I'd point it out 🌹

@basarat
Copy link
Contributor Author

basarat commented Apr 25, 2015

Worth mentioning

I've sent a PR : #2917

@mhegazy
Copy link
Contributor

mhegazy commented May 6, 2015

Since these are not needed i am going to close this issue. We wanted to limit the public API surface area, for support and maintenance reasons. so unless you need them, I would keep them hidden :)

@mhegazy mhegazy closed this as completed May 6, 2015
@mhegazy mhegazy added the Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it label May 6, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it
Projects
None yet
Development

No branches or pull requests

2 participants