Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop of projectLoadingStart for file opened from sharepoint #30818

Closed
mjbvz opened this issue Apr 8, 2019 · 2 comments · Fixed by #31818
Closed

Loop of projectLoadingStart for file opened from sharepoint #30818

mjbvz opened this issue Apr 8, 2019 · 2 comments · Fixed by #31818
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 8, 2019

TypeScript Version: 3.4.1

Search Terms:

  • Sharepoint
  • projectLoadingStart
  • windows

Code
In sharepoint, create a project:

tsconfig.json   // from tsc --init
x.js    // empty
  1. Open vscode

  2. Run the open file command

  3. Browse to the network share for sharepoint (for example \\microsoft.sharepoint.com@SSL\teams\VSCode68\Shared Documents\General\jt-ts-test-workspace) Don't map the drive, just paste that unc style path in the windows explorer

  4. Open x.js

Bug:
This seems to cause an infinite loop of project loads

[Trace  - 2:38:18 PM] Event received: projectLoadingStart (0).
Data: {
    "projectName": "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/tsconfig.json",
    "reason": "Change in config file detected"
}
[Trace  - 2:38:19 PM] Event received: projectLoadingFinish (0).
Data: {
    "projectName": "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/tsconfig.json"
}
[Trace  - 2:38:19 PM] Event received: configFileDiag (0).
Data: {
    "triggerFile": "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/tsconfig.json",
    "configFile": "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/tsconfig.json",
    "diagnostics": []
}
[Trace  - 2:38:19 PM] Event received: projectsUpdatedInBackground (0).
Data: {
    "openFiles": [
        "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/x.js"
    ]
}
[Trace  - 2:38:19 PM] Sending request: geterr (16). Response expected: yes. Current queue length: 0
Arguments: {
    "delay": 0,
    "files": [
        "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/x.js"
    ]
}
[Trace  - 2:38:19 PM] Event received: syntaxDiag (0).
Data: {
    "file": "
    //microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/x.js",
    "diagnostics": []
}
[Trace  - 2:38:19 PM] Event received: semanticDiag (0).
Data: {
    "file": "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/x.js",
    "diagnostics": []
}
[Trace  - 2:38:19 PM] Event received: suggestionDiag (0).
Data: {
    "file": "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/x.js",
    "diagnostics": []
}
[Trace  - 2:38:19 PM] Async response received: requestCompleted (16). Request took 8 ms.
[Trace  - 2:38:20 PM] Event received: projectLoadingStart (0).
Data: {
    "projectName": "//microsoft.sharepoint.com@SSL/teams/VSCode68/Shared Documents/General/jt-ts-test-workspace/tsconfig.json",
    "reason": "Change in config file detected"
}

Playground Link:

Related Issues:

@sheetalkamat
Copy link
Member

sheetalkamat commented Jun 7, 2019

Since x.js isn't part of tsconfig.json next to eat, we are looking and then watching for tsconfig and jsconfig files till root (which happens to be //microsoft.sharepoint.com@SSL since there is no project root.) This makes us watch for //microsoft.sharepoint.com@SSL/tsconfig.json and //microsoft.sharepoint.com@SSL/jsconfig.json which seem to be invoked multiple times. To me it seems like we should put same restriction to watching files at these locations as we do for failed lookup directories

@David263
Copy link

So strange that this Issue is closed. Infinite loop is still happening in October, even when no JavaScript files have been opened. There are several duplicate bug reports for this same or a similar issue in the VSCode editor (see microsoft/vscode#68896). Each is closed to new postings yet the bug hasn't been fixed as of this version:

Version: 1.39.2 (system setup)
Commit: 6ab598523be7a800d7f3eb4d92d7ab9a66069390
Date: 2019-10-15T15:35:18.241Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
4 participants