-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish @types
Packages to the GitHub Registry
#33330
Comments
@types
Packages to GitHub@types
Packages to the GitHub Registry
This comment has been minimized.
This comment has been minimized.
Here's the current plan: SummaryAutomatic Type Acquisition will slowly move over to the github package registry completely. All 3.7-beta (October)
3.8 (November with release in January)
3.9
4.0
Addendum: Transitive skeletal dependentsIf we publish to @types on github, skeletal dependents are not needed to resolve DT packages correctly. They would solely improve performance when ATA installs non-@types dependencies.
On @definitelytyped/*, publish versions of npm packages stripped of everything but d.ts files.
Benefits
NotesI believe github's proxy will already cache dependents of @definitelytyped/* packages, so skeletal depedents would only reduce the number of times that ATA installs an npm-based package from 1 (with caching) to 0 (with a skeletal dependent on GHPR), whereas today it's one for each time an @types/* package depends on it. So less load on npm is already part of @definitelytyped/* packages. For the other 3 benefits, we need to know:
Open design questions
E.g, a JS user installs Evaluation ideas
|
We had a couple companies a long time ago ask for ATA to be able to be configured to point at an internal registry. This'll effectively enable that. |
@weswigham Only if the registry or the package name is configurable, right? I was literally thinking of installTypesRegistry('github') || installTypesRegistry('npm') for 3.8. |
Very presumptuous ;) |
Well, I mean, I think enabling all custom registries follows the "zero, one, or infinity possibilities" rule. |
Update: As of this morning, types-publisher is publishing updates to packages at @testtypepublishing/*. I'll watch it for a while to shake the bugs out. When I have time I'll write a script to fill in old versions of packages as well. |
@sandersn you wanna update the summary here with the results of today's discussion? |
Yes, and the schedule needs to be updated as well. |
Moving to 3.9; the 3.8 parts of this task are done. |
This is actually more likely to be 4.1, but that's not a milestone yet. |
After discussing this, we decided that this feature doesn't make sense with Microsoft owning both github and npm. There's no gain in redundancy anymore. |
Today,
@types
packages are only published to the npm registry. This accounts for a large amount of traffic, in large part because of automatic type acquisition (ATA), a feature that leverages@types
packages to provide code completion (a.k.a. IntelliSense) for JavaScript users. Because this functionality is crucial for editors, it's important to provide a source of redundancy to ensure reliability. Additionally, this is a good way to give users an option to select their registry.The text was updated successfully, but these errors were encountered: